Closed Bug 444917 Opened 12 years ago Closed 11 years ago

Port |Bug 388504 – It should be possible for an extension to reload Page Info on a different document| to SeaMonkey

Categories

(SeaMonkey :: Page Info, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: sgautherie, Assigned: philip.chee)

References

Details

Attachments

(1 file, 1 obsolete file)

I noticed it in bug 405105 comment 2.

While this may not have been the purpose there,
I don't see why we wouldn't want to do it here...
Blocks: FF2SM
Assignee: db48x → nobody
QA Contact: page-info
Blocks: 86400
I need to fix this before I can continue on Bug 86400
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Blocks: 491310
Attached patch Patch 0.2 WIP. (obsolete) — Splinter Review
First cut. This patch could do with some improvement but I'm tired at staring at the code. I'm putting this up for review so that comments can be made.

+function showTab(id)
+  var selectedTab = document.getElementById(id) ||
+                    document.getElementById(id + "Tab") || // Firefox compatibility sillyness 

Just in case some Firefox extension wants to use showTab()

 function onClickMore()
 {
-  var tabbox = document.getElementById("tabbox");
-  var tab = document.getElementById("securityTab");
-  tabbox.selectedTab = tab;
+  showTab("securityTab");

This is called only once. If we don't care about Firefox compatibility at this level we can remove this and call showTab directly.

+++ b/suite/browser/pageinfo/permissions.js

I'm not sure if I have the right number of add/remove observers. I feel all this can be vastly simplified if we can just hide the permissions pane - which is totally useless - for non http(s) pages. FWIW we already hide the feeds tab when there are no feeds.
Attachment #380820 - Flags: review?(neil)
Attachment #380820 - Flags: review?(neil) → review+
Comment on attachment 380820 [details] [diff] [review]
Patch 0.2 WIP.

Didn't test this, there's no UI for it yet.

>+  while (feedListbox.firstChild)
Nit: .hasChildNodes()

>+    feedListbox.removeChild(feedListbox.firstChild);
Nit: .lastChild

>+  tabbox.selectedTab = selectedTab;
>+  tabbox.selectedTab.focus();
Nit: don't need tabbox. the second time.

>-  if(/^https?/.test(uri.scheme)) {
>+  if(/^https?/.test(gPermURI.scheme)) {
Might as well fix these to have a space after if while we're here.
[Though I do wonder why it's based on the scheme, not the host...]
> (From update of attachment 380820 [details] [diff] [review])
carrying forward r+=Neil

> Didn't test this, there's no UI for it yet.
I have the ExecuteJS extension installed <http://xsidebar.mozdev.org/modifiedmisc.html#executejs>. I open the pageInfo window then navigate to various URLs. Then I run the following code in the context of the pageinfo window:

var xxfoo = {doc: window.opener.gBrowser.contentWindow.document, initialTab: "mediaTab"}
resetPageInfo(xxfoo);

>>+  while (feedListbox.firstChild)
> Nit: .hasChildNodes()
Fixed.

>>+    feedListbox.removeChild(feedListbox.firstChild);
>Nit: .lastChild
Fixed.

>>+  tabbox.selectedTab = selectedTab;
>>+  tabbox.selectedTab.focus();
> Nit: don't need tabbox. the second time.
Fixed.

>>-  if(/^https?/.test(uri.scheme)) {
>>+  if(/^https?/.test(gPermURI.scheme)) {
> Might as well fix these to have a space after if while we're here.
Fixed.
Attachment #380820 - Attachment is obsolete: true
Attachment #380862 - Flags: review+
Attachment #380862 - Flags: superreview+
Attachment #380862 - Attachment description: Patch v1.0 → [for checkin] Patch v1.0
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
Comment on attachment 380862 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/86f9ec8efa43
Attachment #380862 - Attachment description: [for checkin] Patch v1.0 → Patch v1.0 [Checkin: Comment 5]
No longer blocks: FF2SM
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.