405137 - Close button on tab has empty tooltip

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Kroc Camen]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1

A tiny yellow square appears when hovering over the close button on a tab

Reproducible: Always

Steps to Reproduce:
1. Open two tabs
2. Hover mouse over the close button
Actual Results:  
Small yellow square appears representing a blank tooltip

Expected Results:  
No tooltip square, or a tooltip to say that this is the close button

My be related to: #403330

Comment 1

[Phil Ringnalda (:philor)]

Aren't you missing step 0, "install the prototype of the new Mac theme, which extends the binding that has the tooltip content, and thus loses it"?

Comment 2

[Kroc Camen]

Hey, I'm just a user. No idea how the internals work :) I was meant to add that I was using Proto, but have just realised I forgot to add it to the report :/

Comment 3

[Phil Ringnalda (:philor)]

Well, you're forgiven for not adding the second part. And since it looks like the patch in bug 397723 has the same problem, and it's really only a bug in a patch that hasn't been checked in yet, let's deal with it over there.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 5

[(not reading, please use [e-mail] instead)]

phil, based on comments from faaborg, I think we want to re-open this and block on bug #397723, so that it doesn't get lost in the shuffle.

proto 0.8

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007121008 Minefield/3.0b2pre

Comment 6

[Samuel Sidler (old account; do not CC)]

And we want to confirm it too.

Comment 7

[Phil Ringnalda (:philor)]

Blocked 2.0 the last time around, in bug 324237, so I guess it ought to again.

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Is it wrong to laugh maniacally while thinking "(as long as this test is actually enough) this will be the last time I fix this particular bug"?

Comment 9

[Asaf Romano (gone)]

Comment on attachment 299732 [details] [diff] [review]
Fix v.1

sure you don't need both hasAttribute and getAttribute != "", r=mano otherwise.

Comment 10

[Phil Ringnalda (:philor)]

That double test somehow seemed to make sense to me at the time, where "the time" seems to have been a quarter to four in the morning. Maybe I expected my test to run in IE?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299732 [details] [diff] [review]
Fix v.1

a=beltzner

Comment 12

[Phil Ringnalda (:philor)]

browser/themes/pinstripe/browser/browser.xml 1.6
browser/base/content/test/browser_bug405137.js 1.1
browser/base/content/test/Makefile.in 1.7

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre ID:2008013004