Closed
Bug 405303
Opened 17 years ago
Closed 17 years ago
Add ID to View -> Layout menupopup to make overlaying easier for extensions (e.g. Lightning)
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3
People
(Reporter: sipaq, Assigned: sipaq)
Details
(Keywords: verified1.8.1.12)
Attachments
(1 file)
1.63 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
dveditz
:
approval1.8.1.12+
|
Details | Diff | Splinter Review |
The View -> Layout menupopup currently doesn't have an ID, which makes it really hard for extensions to hook up to this menu. See http://mxr.mozilla.org/mozilla/source/calendar/base/content/today-pane.js#92 up until line 111 to see the ugliness, that this caused to Lightning for example. Since this is an extremely low-risk patch, it would be good to get this on the 1.8 branch as well, as we're (Lightning Team) are currently doing most of our development there.
Attachment #290100 -
Flags: superreview?(bienvenu)
Attachment #290100 -
Flags: review?(bienvenu)
Attachment #290100 -
Flags: approval1.8.1.10?
Updated•17 years ago
|
Attachment #290100 -
Flags: superreview?(bienvenu)
Attachment #290100 -
Flags: superreview+
Attachment #290100 -
Flags: review?(bienvenu)
Attachment #290100 -
Flags: review+
Assignee | ||
Comment 1•17 years ago
|
||
Comment on attachment 290100 [details] [diff] [review] Add ID Justification for branch approval: Extremely low-risk, as this patch only adds an ID to a menupopup. High gain, as this would make it much easier for extension authors (e.g. Lightning) to overlay that menupopup. Currently we have to hack around this.
Attachment #290100 -
Flags: approval1.8.1.11?
Updated•17 years ago
|
Attachment #290100 -
Flags: approval1.8.1.10?
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.8.1.12?
Comment 2•17 years ago
|
||
Not "blocking", but probably a reasonable thing to approve.
Flags: blocking1.8.1.12? → blocking1.8.1.12-
Comment 3•17 years ago
|
||
Comment on attachment 290100 [details] [diff] [review] Add ID approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #290100 -
Flags: approval1.8.1.12? → approval1.8.1.12+
Assignee | ||
Comment 4•17 years ago
|
||
Checkin is needed on both trunk and MOZILLA_1_8_BRANCH.
Keywords: checkin-needed
Comment 5•17 years ago
|
||
Can I talk you into the very same patch for SM? :) In general, we try to keep ids in sync, and most of the UI is similar enough...
Assignee | ||
Comment 6•17 years ago
|
||
Karsten, it's probably easiest if I simply provide a 2nd patch in bug 411481 that covers SeaMonkey as well.
Comment 7•17 years ago
|
||
That'd be nice. :)
Comment 8•17 years ago
|
||
HEAD: Checking in mail/base/content/mailWindowOverlay.xul; /cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v <-- mailWindowOverlay.xul new revision: 1.231; previous revision: 1.230 done MOZILLA_1_8_BRANCH: Checking in mail/base/content/mailWindowOverlay.xul; /cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v <-- mailWindowOverlay.xul new revision: 1.116.2.82; previous revision: 1.116.2.81 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed → fixed1.8.1.12
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Comment 9•16 years ago
|
||
I've verified that this is checked in for branch (which is about all to be done here).
Keywords: fixed1.8.1.12 → verified1.8.1.12
You need to log in
before you can comment on or make changes to this bug.
Description
•