405303 - Add ID to View -> Layout menupopup to make overlaying easier for extensions (e.g. Lightning)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Simon Paquet [:sipaq]]

Attachment: Add ID

The View -> Layout menupopup currently doesn't have an ID, which makes it really hard for extensions to hook up to this menu.

See http://mxr.mozilla.org/mozilla/source/calendar/base/content/today-pane.js#92 up until line 111 to see the ugliness, that this caused to Lightning for example.

Since this is an extremely low-risk patch, it would be good to get this on the 1.8 branch as well, as we're (Lightning Team) are currently doing most of our development there.

Comment 1

[Simon Paquet [:sipaq]]

Comment on attachment 290100 [details] [diff] [review]
Add ID

Justification for branch approval:

Extremely low-risk, as this patch only adds an ID to a menupopup. High gain, as this would make it much easier for extension authors (e.g. Lightning) to overlay that menupopup. Currently we have to hack around this.

Comment 2

[Daniel Veditz [:dveditz]]

Not "blocking", but probably a reasonable thing to approve.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 290100 [details] [diff] [review]
Add ID

approved for 1.8.1.12, a=dveditz for release-drivers

Comment 4

[Simon Paquet [:sipaq]]

Checkin is needed on both trunk and MOZILLA_1_8_BRANCH.

Comment 5

[Karsten Düsterloh]

Can I talk you into the very same patch for SM? :)
In general, we try to keep ids in sync, and most of the UI is similar enough...

Comment 6

[Simon Paquet [:sipaq]]

Karsten, it's probably easiest if I simply provide a 2nd patch in bug 411481 that covers SeaMonkey as well.

Comment 7

[Karsten Düsterloh]

That'd be nice. :)

Comment 8

[Reed Loden [:reed]]

HEAD:

Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.231; previous revision: 1.230
done


MOZILLA_1_8_BRANCH:

Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.116.2.82; previous revision: 1.116.2.81
done

Comment 9

[Al Billings [:abillings - ex-MoCo]]

I've verified that this is checked in for branch (which is about all to be done here).