405683 - content pref service doesn't update version when migrating from 2 to 3

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

The content pref service doesn't update the database schema version when migrating the schema from version 2 to version 3 (per bug 403375), which causes it to try again the next time the browser is started.  But the second and subsequent migration attempts fail, as the schema is already at version 3, which makes the content pref service unavailable, so full zoom prefs don't work.

Here's a patch that fixes the problem.  It refactors the version number change to reduce the possibility of this bug recurring and makes the index creation function succeed even if the indexes already exist to fix databases that are currently in the inconsistent state.

Comment 1

[Mike Connor [:mconnor]]

Comment on attachment 290447 [details] [diff] [review]
patch v1: fixes problem

r=me

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 290447 [details] [diff] [review]
patch v1: fixes problem

Requesting approval for this regression fix from a recent check in of a 1.9 blocker.

Comment 4

[John P Baker]

Does this (esp. bug 405697) mean that the init and destroy of FullZoom should be protected with a

if this._cps

to reduce the effect if the content pref service _is_ unavailable?

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 290447 [details] [diff] [review]
patch v1: fixes problem

a=beltzner for drivers

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Checking in toolkit/components/contentprefs/src/nsContentPrefService.js;
/cvsroot/mozilla/toolkit/components/contentprefs/src/nsContentPrefService.js,v  <--  nsContentPrefService.js
new revision: 1.13; previous revision: 1.12
done