405809 - Replacement tango icons

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Michael Monreal [:micmon]]

This is a pack of replacement icons in tango style that should not need any CSS changes, they just replace the old version.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Icons

The tar includes 16x16 icons for search folders, tags, generic application, tab drag indicator, popup blocker, search not found, search wrapped and extensions.

They are already named as their current counterparts.

Comment 2

[Michael Monreal [:micmon]]

For got to mention: also included is identity.png, which has tango versions of "Identity Unknown", "Identity SSL" and "Identity EV"

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/themes/gnomestripe/browser/Info.png 	1.4
mozilla/browser/themes/gnomestripe/browser/identity.png 	1.2
mozilla/browser/themes/gnomestripe/browser/preferences/application.png 	1.3
mozilla/browser/themes/gnomestripe/browser/tabbrowser/tabDragIndicator.png 1.2
mozilla/browser/themes/gnomestripe/browser/places/query.png 	1.3
mozilla/browser/themes/gnomestripe/browser/places/tag.png 	1.2 
mozilla/toolkit/themes/gnomestripe/Makefile.in 	1.3
mozilla/toolkit/themes/gnomestripe/global/jar.mn 	1.17
mozilla/toolkit/themes/gnomestripe/mozapps/Makefile.in 	1.1
mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn 	1.1
mozilla/toolkit/themes/gnomestripe/mozapps/places/tagContainerIcon.png 	1.1
mozilla/toolkit/themes/gnomestripe/mozapps/update/update.png 	1.1
mozilla/toolkit/themes/gnomestripe/global/icons/notfound.png 	1.1
mozilla/toolkit/themes/gnomestripe/global/icons/wrap.png 	1.1

Toolkit portions checked in with new overrides and makefiles. a=mconnor as part of gnomestripe.

Comment 4

[Dennis Jacobfeuerborn]

The new icon for the drag&drop hovering over a folder in the bookmark toolbar seems to be missing from the list. Fixing that should also fix bug 342166.

Comment 5

[Michael Monreal [:micmon]]

Fennis J.: The problem you described has nothing to do with this bug.

Comment 6

[Michael Monreal [:micmon]]

Well, the little (16x16) extensions icon is in now, but the bar that pops up when you install extensions from a currently blocked site ("Minefield prevents this site from asking you to install software...") still uses the old icon.

Is this currently using the 32x32 version? If yes, it should just use the 16x16 version that is now upstream. The popup blocker also uses a 16x16 icon in this bar, which seems to be correct.

Comment 7

[Michael Monreal [:micmon]]

I'm also wondering about the "History" item in places, this should not use "Search folder" but the history icon, right?

Comment 8

[Reed Loden [:reed]]

Again, reopen the bug, don't change to INCOMPLETE.

Comment 9

[Reed Loden [:reed]]

(or file a new bug) :)

Comment 10

[Ryan Flint [:rflint] (ping via IRC for reviews)]

This was just a simple icon replacement. Issues with the implementation should be filed as new bugs.