406254 - because we bold the selected text, the text shifts to the right (slightly) as you continue to match

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

because we bold the selected text, the text shifts to the right (slightly) as you continue to match.

sayre pointed this one out.

one suggestion he had was using black for the matching text and grey for the non-matching text.  (and dark green vs not-as-dark green for the matching url)

Comment 1

[(not reading, please use [e-mail] instead)]

using bold appears to have other issues, see bug #407861 "Bolding the found text in autocomplete breaks ligatures "

Comment 2

[Simon Bünzli]

(In reply to comment #0)
> one suggestion he had was using black for the matching text and grey for the
> non-matching text.

That'll lead to a variation of bug 409974, though. What about using HighlightText/Highlight instead? Won't look great, but it won't look out of place, either.

Comment 4

[scratch]

how about using -moz-opacity: .8 or so on unmatched text?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #4)
> how about using -moz-opacity: .8 or so on unmatched text?

Alex, would that be a possible way?

Comment 6

[Dietrich Ayala (:dietrich)]

Not going to block the 3.1 release for this. Alex Faaborg has recently talked about using contrasting colors instead of bold+underline to resolve this issue.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> Not going to block the 3.1 release for this. Alex Faaborg has recently talked
> about using contrasting colors instead of bold+underline to resolve this issue.

Dietrich, could you please set the flags accordingly?

Comment 8

[Tony Mechelynck [:tonymec]]

(In reply to comment #6)
> Not going to block the 3.1 release for this. Alex Faaborg has recently talked
> about using contrasting colors instead of bold+underline to resolve this issue.

Of course, "contrasting" colors, when foreground-only (i.e., red vs. blue but not white-on-black vs. black-on-white) can be a problem for color-blind users. Maybe the underline should be kept.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Possible formatting changes

Here is a mockup of possible formatting changes.  This doesn't address the text shifting problem, since we are still using bold, but does clean up the appearance a little by removing the underlines and using contrast for emphasis.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

This effects every interaction with the awesome bar, so definitely something that users will encounter several times a day.

Comment 11

[Andrew Hurle [:ahurle]]

This is fixed by bug 587909, which removes the bold.  Varying opacity may happen in bug 774118.