Closed
Bug 406414
Opened 17 years ago
Closed 13 years ago
Problem compiling for nsIMsgDBView support due to rule ordering issues in mail/build.mk
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: christianha1111, Assigned: christianha1111)
Details
Attachments
(3 files)
2.17 KB,
patch
|
Details | Diff | Splinter Review | |
170.33 KB,
application/x-zip-compressed
|
Details | |
808 bytes,
patch
|
benjamin
:
review+
mscott
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; FDM; .NET CLR 1.1.4322)
Build Identifier: version 3.0a1pre (2007120112)
The problem is that if you try to build your own component which needs i.e. nsIMsgDBView.h the build stops. nsIMsgDBView is included in msgbase. Unfortunately msgbase isn't created yet. The solution is to change mail/build.mk.
Please find the solution attached thx to "standard8".
Reproducible: Always
Steps to Reproduce:
1. include own extension which needs nsIMsgDBView.h
2. build everything
3.
Actual Results:
build stops with error:
fatal error C1083: Cannot open include file: 'nsIMsgDBView.h': No such file or directory
Expected Results:
successful build
Assignee | ||
Comment 1•17 years ago
|
||
Assignee | ||
Comment 2•17 years ago
|
||
Comment 3•17 years ago
|
||
Please attach a diff, not the complete new file. gStand in the mozilla dir and do cvs diff -up9
You also need to get the reviewed, see http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree
Assignee | ||
Comment 4•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Attachment #291089 -
Flags: review?(benjamin)
Comment 5•17 years ago
|
||
Comment on attachment 291089 [details] [diff] [review]
This is the output of the diff. Hopefully that's the right way to post it.
Looks ok to me, but a mailnews owner should give moa as well
Attachment #291089 -
Flags: review?(mscott)
Attachment #291089 -
Flags: review?(benjamin)
Attachment #291089 -
Flags: review+
Updated•17 years ago
|
Attachment #291089 -
Flags: review?(mscott) → review+
Updated•17 years ago
|
Assignee: nobody → christianha1111
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•17 years ago
|
Keywords: checkin-needed
Updated•17 years ago
|
Summary: Problem with mail/build.mk (solution Attached) → Problem compiling for nsIMsgDBView support due to rule ordering issues in mail/build.mk
Comment 6•17 years ago
|
||
Checking in mail/build.mk;
/cvsroot/mozilla/mail/build.mk,v <-- build.mk
new revision: 1.5; previous revision: 1.4
done
Assignee | ||
Comment 7•13 years ago
|
||
Bug 444686 undid this change. the problem reappeared
Severity: major → normal
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•13 years ago
|
||
Please don't re-open old bugs that were fixed. Please file a new bug - then we can track regression points better.
Severity: normal → major
Status: REOPENED → RESOLVED
Closed: 17 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•