Closed Bug 406576 Opened 12 years ago Closed 12 years ago

Investigate calIcalProperty::setDatetime_ for parentless properties (possible timezone issue)

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbo, Assigned: dbo)

Details

Attachments

(1 file)

follow-up for bug 400950:
The mentioned code may run into setting a TZID parameter although there's (yet) no parent to add the referenced VTIMEZONE to. AFAIK this may currently occur for EXDATE/RDATEs.
Flags: wanted-calendar0.8+
Status: NEW → ASSIGNED
Flags: blocking-calendar0.8+
In case no parent VCALENDAR is present, this patch coerces the DATE-TIME property to either UTC or keep it floating.
Attachment #299188 - Flags: review?(ctalbert)
Comment on attachment 299188 [details] [diff] [review]
coerce to either UTC or keep floating

Looks good.  Thanks.
r=ctalbert
Attachment #299188 - Flags: review?(ctalbert) → review+
Test Notes: Create a recurring event every day.  Make a recurring exdate that removes say every thursday, and then you change to or from DST (the opposite of when that date was created) or update the timezone definition so that a DST rule now applies, then you must check to see if the wrong day gets ommitted.  For example, every wednesday disappears instead of every thursday.

Setting QAWanted to check that^
Keywords: qawanted
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Flags: in-testsuite?
Keywords: qawanted
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.