406907 - rich autocomplete results should use comma instead of space as the label separator

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

should rich autocomplete use comma instead of space as the label separator?

this is a question for the accessibility gurus.

when using Microsoft Narrator, the title, url and type ("Tag" or "Bookmark") sort of run together.

would it better to use a comma, semicolon, or some other punctuation so that users can better determine what is what?

Comment 1

[Aaron Leventhal]

Another question is whether for http:// URL's whether we could trim the "http://" off. Maybe even the "www" off when that exists as well. It takes a long time for the TTS to read "http://www" a number o ftimes.

That might be nice for the visual rendering as well. It's less to have to scan with your eyes, which might be nice.

Comment 2

[(not reading, please use [e-mail] instead)]

there is a bug already about not showing http:// visually, I'll find it.

trimming it from the label (for screen readers) would be very easy.

if you think that is a win, let's log a separate bug about that.

as for this bug, we use " " instead of "," in other parts of the code

for example, http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/content/extensions.xml#186

aaron, would adding some punctuation to pause between elements be a good idea?

Comment 3

[Aaron Leventhal]

I'll defer to Marco on it, as well as whether to file a separate bug for simplifying the URL string.

Comment 4

[Marco Zehe (:MarcoZ)]

Both ideas are great! A comma is the best choice, IMO, because screen readers usually pause at a comma, but usually don't speak the comma as "comma", unless punctuation is set to an absolute maximum verbosity. Trimming "http://"", and if present, "www." is also a good way to straighten this feature. Seth, if it's so easy to trim, why don't you just roll everything into one patch?

Comment 5

[(not reading, please use [e-mail] instead)]

let's make this bug just cover comma (and we should log additional bugs about other places where we should use comma instead of " ", for example http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/content/extensions.xml#186)

as for stripping the http:// and http://www, I've taken that to bug #407217

I'd prefer to keep one issue per bug, if possible.

Comment 6

[(not reading, please use [e-mail] instead)]

the fix for this bug should be very simple:

1) http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/autocomplete.xml#1138

1138            return title + " " + url;

replace " " with "," (or " , " not sure, will have to test with narrator)

2) http://lxr.mozilla.org/seamonkey/source/browser/base/content/urlbarBindings.xml#391

391             var label = aTitle + " " + aUrl;

here, too.

3)  http://lxr.mozilla.org/seamonkey/source/browser/base/content/urlbarBindings.xml#391

396               label += " " + this._bundle.GetStringFromName(aType + "ResultLabel");

here, too.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.