407020 - Dragging images to iTunes album artwork control fails - works in Safari

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Robin Whittleton]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre

Dragging an image out of Firefox to iTunes album art control (or other image input) fails. The input control highlights by adding a blue border, but dropping the dragged image on it does nothing. I knocked together a quick interface in Interface Builder with just a single nsImageView and this demonstrates the same problem.

This works fine in Safari 3.

Reproducible: Always

Steps to Reproduce:
1. Load iTunes, right-click on a track, and select Get Info
2. Click on the artwork tab
3. Go to Firefox and load a webpage with an image
4. Drag the image over to the artwork image field in iTunes
Actual Results:  
The input highlights with a blue border, but dropping the image does nothing.

Expected Results:  
The image is added to the input (see Safari's behaviour).

Comment 1

[Jean-Yves Perrier [:teoli]]

I can confirm that behaviour on 10.5.1. More, this is a regression as a blank new install of Firefox 2.0.0.11 allows this behaviour. (I don't have the ability to set this bug to NEW and/or add a keyword)

Comment 2

[philippe (part-time)]

Yeah I see the same issue with a Camino trunk build.
And it works correctly with Camino 1.5.4/Fx 2.0.0.11.

Comment 3

[Stan Shebs]

Hmm, according to DragPeeker, all the flavors of data are there, but they are all empty, and I'm pretty sure that's not how it was working the last time I did a drag bug. Setting to P2.

Comment 4

[Stan Shebs]

This seems to be caused by the patch for bug 400028 ; I reverted it, and the iTunes drag works with current trunk again.

Comment 5

[Stan Shebs]

A little more investigation suggests that there is something that is undesirable about creating the PICT data with the helper function AddImageDataToPasteboardDict, vs letting the system do it. If I just create a TIFF, dragging works fine; but neither PICT alone, nor TIFF and PICT (created in either order) will work. It's as if the PICT is looked at first by the receiver, found to be wrong in some way, and then the app rejects the drag without looking at the TIFF. Clipboard Viewer does show differences between the browser-generated and system-generated PICTs, although when saved to a file, both render OK.

Comment 6

[Andrea Guglielmi]

I don't know if this is useful or not but dragging a picture from latest builds to Bruji's DVDpedia (http://www.bruji.com/dvdpedia/) window (I tried on almost every window I could change the DVD image) works as designed.

Comment 8

[Josh Aas]

fixed by backing out bug 400028

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050704 Minefield/3.0pre.