Closed
Bug 407206
Opened 17 years ago
Closed 17 years ago
rewrite calTimezoneService::GetTimezone
Categories
(Calendar :: Internal Components, enhancement)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mvl, Assigned: mvl)
Details
Attachments
(1 obsolete file)
I'm sorry, but calTimezoneService::GetTimezone it not readable. The flow jumps up and down, and the important stuff happens hidden somewhere in if statements. It can be much more readable.
(yes, I do plan to make an attempt)
|
||
Comment 1•17 years ago
|
||
You don't need to be sorry, I am open to any code improvements ;)
But I think this is a useless attempt since Clint will work out timezone database lookup anyway and replace that particular code: we will get rid of the static tzdata.c lookup.
Severity: normal → enhancement
Version: Trunk → unspecified
|
Assignee | |
Comment 2•17 years ago
|
||
This version is cleaner, imho.
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 301024 [details] [diff] [review]
a rewrite
I think obsolete now; bug 363191 has removed that file.
Attachment #301024 -
Attachment is obsolete: true
Attachment #301024 -
Flags: review?(daniel.boelzle)
|
|
||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•