407334 - moz-icon crashes on windows for non-existent/missing drives [@ _wgetdcwd - nsLocalFile::Normalize]

Status: VERIFIED DUPLICATE of bug 419326

(Core :: Graphics: ImageLib, defect)

Description

[Lee Houghton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120605 Firefox/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120605 Minefield/3.0b2pre ID:2007120605

The crash is in nsLocalFile::Normalize, which is calls _getdcwd with an invalid drive letter. 

Reproducible: Always

Steps to Reproduce:
1. Visit moz-icon:file:///X:/ where X is the letter of a drive that does not exist

Actual Results:  
Breakpad shows.

Expected Results:  
An appropriate icon is displayed.

I believe this depends on bug 281951, but it seems I can't set that here. Similar to bug 236227 but different cause.

Attaching a stack trace I got from visual studio.

Comment 1

[Lee Houghton]

Attachment: Stack trace

Comment 2

[Marcia Knous [:marcia]]

Confirming, I see this using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007120705 Minefield/3.0b2pre. I followed the STR and crashed, although at the moment Breakpad seems to be failing to submit crashes.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This doesn't crash for me in XP - Vista only?

Comment 4

[Lee Houghton]

It crashes my windows XP too, with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120805 Minefield/3.0b2pre

Comment 5

[timeless]

http://msdn2.microsoft.com/en-us/library/7t2zk3s4(VS.80).aspx
Maximum length of the path in characters:
  char for _getdcwd and wchar_t for _wgetdcwd.
Return Value
  Returns buffer. A NULL return value indicates an error, and errno is set either to ENOMEM, indicating that there is insufficient memory to allocate maxlen bytes (when a NULL argument is given as buffer), or to ERANGE, indicating that the path is longer than maxlen characters.

  If the drive does not specify a valid drive or if maxlen is less than or equal to zero, this function invokes an invalid parameter handler, as described in Parameter Validation.

This last bit is the key. Thou shalt not specify an invalid drive to this function.

Comment 6

[Lee Houghton]

This was fixed by attachment 306132 [details] [diff] [review] in bug 419326.

Comment 7

[timeless]

sorry about not using the oldest bug.