407540 - Tags checked when they are created for a different bookmark

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Carsten Book [:Tomcat]]

Attachment: wrong checked tag

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007120804 Minefield/3.0b2pre

There are tags checked in places organizer for bookmarks when they are created for a different bookmark.

See Attached screenshot. For the Bookmark of Bug 400109 is the "uuuu" checked but not listed in the "tag" summary. The tag "uuuu" was created for the Bookmark of Bug 334049.

Steps to reproduce:
Ensure you have some bookmarks
Create a new Bookmark via "bookmark this site" add a tag to this bookmark
Open the Places Organizer and check your bookmarks
All the bookmarks in the folder have the same tag.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 293178 [details] [diff] [review]
patch

r=sspitzer

but I think it might be be better to always call this._rebuildTagsSelectorList();, and in _rebuildTagsSelectorList(), do:

var tagsSelector = this._element("tagsSelector");
+ if (tagsSelector.collapsed) 
+  return;

what do you think?

Comment 3

[Asaf Romano (gone)]

Attachment: with that change

Comment 4

[Asaf Romano (gone)]

mozilla/browser/components/places/content/editBookmarkOverlay.js  1.14

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 293184 [details] [diff] [review]
with that change

r=sspitzer, thanks mano!

Comment 6

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre)
Gecko/2007121805 Minefield/3.0b3pre and the equivalent Mac nightly build. 

Comment 8

[Aakash Desai [:aakashd]]

Test case 7453 was created to regression test this bug on FFT and BFT for Firefox 3.1

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't think that the added test covers this regression. You should really mention the details pane. Further a test shouldn't rely on another test. Every test has to be processed on its own. I would propose following steps:

1. Add a bookmark by cmd+d and add the tags "test1", "test2", and "test3"
2. Add another bookmark by cmd+d to the same folder and add the tag "test1"
3. Open the library and select the folder in the left pane
4. Select the bookmark from step 2 and expand the tag list inside the details pane

=> The bookmark should only have the tag "test1" assigned and its appropriate checkbox is checked. All other checkboxes are not checked.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv