407633 - Can't close window via close widget after dragging in bookmark menu

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Matthew Gregan [:kinetik]]

S.T.R.
1. Click and drag bookmark out of bookmarks menu
2. Drop bookmark on browser or cancel drag by pressing escape key
3. Close browser with window decoration close widget or right clicking window decoration and selecting close

E.R.
Normal window close behaviour

A.R.
Close request ignored

Closing via File->Quit or Ctrl-W works fine, so it seems like we get stuck blocking the close/destroy events from the window manager.

Comment 1

[Matthew Gregan [:kinetik]]

The problem is that the menu popup acquires a GTK widget grab when it appears, but does not release the GTK widget grab when it hides if a drag event is in progress when the popup rolls up.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/gtk2/nsWindow.cpp&rev=1.251&root=/cvsroot&mark=1505,1506,1512,1514#1504

I think we should release the GTK widget grab irrespective of a drag being in progress.  I've been testing that change here and it does not seem to break any other DnD behaviour so far, but I'll test further before posting the patch.  We must retain the grabs acquired via GrabPointer/GrabKeyboard in this situation, however, because otherwise events are delivered to the wrong widget during the drag.

Comment 2

[Serge Gautherie (:sgautherie)]

Marking dependent for the time being, per bug 418156 comment 30.

Comment 3

[Matthew Gregan [:kinetik]]

Clearing dep on bug 418156.  I can still reproduce this using a build with that patch applied.  Applying my patch resolves the problem.

Comment 4

[Matthew Gregan [:kinetik]]

Requesting blocking since bug 418156 was blocking, but maybe it's too late in the game for this one.

The fix suggested in comment #1 is trivial, but I want to debug this further to make sure that's the correct fix (and the problem isn't to do with the order grabs are acquired and released).

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Don't think it blocks, but we'd take a fix.

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: ensure to remove widget grabs from CaptureRollupEvents even when a drag has since started

Comment 7

[Karl Tomlinson (:karlt)]

Comment on attachment 510861 [details] [diff] [review]
ensure to remove widget grabs from CaptureRollupEvents even when a drag has since started

(wrong patch)

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: ensure to remove widget grabs from CaptureRollupEvents even when a drag has since started

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: ensure to remove widget grabs from CaptureRollupEvents even when a drag has since started

Comment 10

[Karl Tomlinson (:karlt)]

Comment on attachment 510863 [details] [diff] [review]
ensure to remove widget grabs from CaptureRollupEvents even when a drag has since started

This very low risk patch resolves this unfortunate unable-to-close behaviour that is hard to associate with its cause (dragging from bookmarks).

Comment 11

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/48ef0691b70c