179078 - [gtk2] dnd to personal toolbar doesn't cancel properly

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Christopher Blizzard (:blizzard)]

From Matt Wilson:

Drag a link from the content area to a personal toolbar bookmark
folder.  Keep holding the mouse button.  Wait for the toolbar folder
to open.  Then press Escape to cancel the DnD.  The folder closes, but
the DnD icon doesn't go away until you click on it.

Comment 1

[Bolian Yin]

have similiar symptom with Bug 96504.

Comment 2

[Bolian Yin]

taking

Comment 3

[Bolian Yin]

Attachment: patch

The same to prevent mozilla take grab from gtk as I used in bug #148996

Comment 4

[Bolian Yin]

This patch prevent popmenu grab from gtk dnd, but can not do properly on the
popupped menu due to a gtk2 bug. see
http://bugzilla.gnome.org/show_bug.cgi?id=101512

Comment 5

[Bolian Yin]

included in gtk+-2.2.0 was the fix of
http://bugzilla.gnome.org/show_bug.cgi?id=101512

Comment 6

[kurros (Wade Majors)]

What is the status of this patch?

Comment 7

[Bolian Yin]

waiting for r=blizzard, but it seems he did not get time.

Comment 8

[Bolian Yin]

Attachment: patch (updated gainst current trunk)

Comment 9

[Bolian Yin]

Comment on attachment 107991 [details] [diff] [review]
patch

This is not for mozilla gtk2 build (NOT default build).

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 107991 [details] [diff] [review]
patch

>+PRBool
>+nsWindow::DragInProgress(void)
>+{
>+    // mLastDragMotionWindow means the drag arrow is over mozilla
>+    // sIsDraggingOutOf means the drag arrow is out of mozilla
>+    // both cases mean the dragging is happenning.
>+    if (mLastDragMotionWindow || sIsDraggingOutOf)
>+        return PR_TRUE;
>+    else
>+        return PR_FALSE;

My favorite if-else: just 'return mLastDragMotionWindow || sIsDraggingOutOf;'
and save the source codeprint, if not the compiler cycles optimizing away the
branches.

/be

Comment 11

[Bolian Yin]

Attachment: new patch (with change from Brendan's comment)

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 136646 [details] [diff] [review]
new patch (with change from Brendan's comment)

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 13

[Bolian Yin]

checked in Trunk.