408237 - Non working code due to setting of readonly attribute 'generation' in providers

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.12pre) Gecko/20071213 Calendar/0.8pre

The following warnings were shown in Venkman during event creation/editing:

    Warning "aItem.generation is read-only" [-s] in file 
    "file:///D:/sunbird/js/calStorageCalendar.js", line 362.

    Warning "modifiedItem.generation is read-only" [-s] in 
    file "file:///D:/sunbird/js/calStorageCalendar.js", line 432.

generation is a readonly attribute in calIItemBase:
http://lxr.mozilla.org/mozilla/source/calendar/base/public/calIItemBase.idl#106

Dump statements before and after the modification of generation revealed that the value of generation is always 0:
http://lxr.mozilla.org/mozilla/source/calendar/providers/storage/calStorageCalendar.js#362
http://lxr.mozilla.org/mozilla/source/calendar/providers/storage/calStorageCalendar.js#432

This makes the checks on generation useless because it always passes:
http://lxr.mozilla.org/mozilla/source/calendar/providers/storage/calStorageCalendar.js#421

Similar code is used in other providers, see http://mxr.mozilla.org/mozilla/search?string=generation&find=calendar&findi=&filter=&tree=mozilla

-> Current use of generation is useless because the value is always 0. 
   Either this code should be removed or fixed.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: fix

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 293001 [details] [diff] [review]
fix

r=philipp

Comment 3

[Daniel Boelzle [:dbo]]

Thanks for catching this, Stefan!

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 4

[Daniel Boelzle [:dbo]]

verified this works now