408380 - [404] link to http://www.mozilla.org/access/unix/atspi-support

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Zack Cerza]

Actual broken link is: http://www.mozilla.org/access/unix/atspi-support#events

Probably others too. Looks like the page was migrated, but some links weren't changed?

Comment 1

[David Boswell]

Copying Aaron for input on this bug.

Copying Sheppy since the MDC link in this bug is pointing to an empty page.  I'm not sure if the reporter put in an incorrect URL or if this was a page that got moved but not redirected.

http://developer.mozilla.org/en/docs/Accessibility/AT-SPI_Support

Comment 2

[Eric Shepherd [:sheppy]]

OK, my brain has apparently failed, along with my notetaking skills.  Where is the archive server again? :)

Comment 3

[David Boswell]

http://www-archive.mozilla.org/

You can also find this link on any 404 page on www.mozilla.org.

Comment 4

[Aaron Leventhal]

We should redirect to this:
http://developer.mozilla.org/En/Accessibility:AT-APIs

Comment 5

[Eric Shepherd [:sheppy]]

Looks like this has been done.  Yes?

Comment 6

[David Boswell]

I've set up a redirect so that

http://www.mozilla.org/access/unix/atspi-support

points to

http://developer.mozilla.org/En/Accessibility:AT-APIs

Comment 7

[David Boswell]

Reed, this redirect doesn't seem to be working.  Does the hyphen need to be escaped or is something else wrong with:

RewriteRule ^access/unix/atspi-support(?:/(?:index.html)?)?$ http://developer.mozilla.org/En/Accessibility:AT-APIs [R]

Comment 8

[David Boswell]

Marking as unconfirmed since I'm not seeing this redirect actually working.

Comment 10

[David Boswell]

This problem with the redirect working seems to be the same problem we're seeing in bug 481877.  I'm using the same format for redirects that work for other pages, but in these two instances the redirects don't work.

Comment 11

[franklin]

I believe this rewrite needs to be changed to the following since the colon needs to be escaped.  I've tried to validate this on my workstation but since I'm on windows I can't validate this since you can't use colons in filenames.

Here is the change that I think needs to be made in the .htaccess file:

RewriteRule ^access/unix/atspi-support(?:/(?:index.html)?)?$ http://developer.mozilla.org/En/Accessibility%3AAT-APIs [R]

I changed the : to a %3A to escape the colon

Comment 12

[franklin]

Attachment: Proposed patch for htaccess

Here's my first attempt at creating a patch.  Let me know if there's anything wrong with it.

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 376820 [details] [diff] [review]
Proposed patch for htaccess

Reed can review this.

Comment 14

[Reed Loden [:reed]]

Comment on attachment 376820 [details] [diff] [review]
Proposed patch for htaccess

I don't know if this will work, but it is valid. It's worth trying.

I checked the apache documentation for mod_rewrite, and I didn't see anything as to why that wouldn't work, but googling shows some people complaining, so maybe there is something.

Comment 15

[David Boswell]

I just checked this in, so we'll see what happens.

Franklin, can you try verifying that this works or not in a bit?  It will take up to an hour or so before this shows up on the site.

Comment 16

[franklin]

Will do.  I will verify it when I get home tonight.  Thanks.

Comment 17

[franklin]

I just tried it and we are still getting the 404 unfortunately.

Comment 18

[franklin]

I think I found the cause of the problem.  I was able to replicate this on my machine by monkeying with my hosts file...

There is an .htaccess file in the access/unix/ directory.  It has the following entries.  If I comment out the bottom two entries this appears to start redirecting correctly.

In fact I commented out all the entries and this started to behave as desired.  The only thing that doesn't work is if I specify the url with a slash at the end of it:
http://www.mozilla.org/access/unix/atspi-support/

Question is, will commenting out (or getting rid of the entries in the .htaccess) cause problems elsewhere?

FROM .htaccess:

Redirect permanent atspi-support.html http://developer.mozilla.org/en/docs/Accessibility/ATSPI_Support
Redirect permanent atspi-support http://developer.mozilla.org/en/docs/Accessibility/ATSPI_Support
Redirect permanent /access/unix/atspi-support.html http://developer.mozilla.org/en/docs/Accessibility/ATSPI_Support
Redirect permanent /access/unix/atspi-support http://developer.mozilla.org/en/docs/Accessibility/ATSPI_Support

Comment 19

[franklin]

And I found one more problem.

In the access/unix directory there was an html file called atspi-support.html,  so long as this file was here the rewrite would not get picked up and this file would be returned instead.  Should this file still exist here?

Comment 20

[David Boswell]

Re question in comment #18 about causing problems elsewhere -- we've got a bunch of redirects and no real way to test them other than manually right now, so it's hard to say what may break.  (If there is a good way to test this sort of stuff, let's open a new bug about that).

If this seems to be a larger problem than just how we're redirecting this one particular page though, then it's worth trying to tie this bug in to the other weird redirect bugs we have open (bug 394232 and bug 450490)-- maybe these are all symptoms of the same thing?

Comment 21

[David Boswell]

Re question in comment #19, I assume that the atspi-support.html shouldn't be there.  It often happens that redirected files don't get deleted, so that's probably what happened here.

Note that some directories remove the .html from files in URLs and others don't.  That could be part of this (I had a lot of problems redirecting some pages in the press directory because of this).

Comment 22

[David Bolter [:davidb] (NeedInfo me for attention)]

CC'ing Ginn who probably knows the history of these documents.

Comment 23

[franklin]

Attachment: Proposed patch

This would need to be applied in combination with the removal of the file: 
\html\access\unix\atspi-support.html.

Comment 24

[David Boswell]

I just made the changes mentioned in comment #23.  Please verify after the site has had a chance to update.

Comment 25

[franklin]

Attachment: One more patch...

This needs to be applied since it seems the escaping of characters from the original patch causeda problem.  I just tested it locally and this should fix it.

Comment 26

[David Boswell]

OK, fixed checked in.

Comment 27

[David Boswell]

I just checked this and it is working correctly now.  Thanks Franklin for figuring out the problem.