I've created search engines categories as specified in bug 396741. Unfortunately, the addon edit admin UI complains that you can't put search engines into categories.
Created attachment 296886 [details] [diff] [review]
This patch adds an "All" option for the applications field of categories. If tags.application_id is NULL, it will be available to every add-on in that add-on type. It also fixes a display issue that's been around awhile with clear: both in the admin pages.
This is mainly a temporary fix until the hopeful Dev CP revamp when selecting categories will be way better.
This SQL will need to be run:
ALTER TABLE `tags` CHANGE `application_id` `application_id` INT( 11 ) UNSIGNED default NULL;
UPDATE tags SET application_id=NULL WHERE addontype_id=4;
Comment on attachment 296886 [details] [diff] [review]
The patch is good but we need additional code. If you set a category to "all" and then browse the categories for the extension the category no longer shows up (AddonsController::_browseCategories()). Also, if I try to submit a new search engine, on step 2 of the submission it says "No categories available for this add-on type."
Created attachment 297598 [details] [diff] [review]
Fixes above issues.
Checked in. The SQL in comment 1 will need to be run when this is pushed.
This is live.