408525 - AMO doesn't allow search engines to be placed into categories

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Basil Hashem [:baz]]

I've created search engines categories as specified in bug 396741. Unfortunately, the addon edit admin UI complains that you can't put search engines into categories.

Comment 1

[Justin Scott [:fligtar]]

Attachment: patch

This patch adds an "All" option for the applications field of categories. If tags.application_id is NULL, it will be available to every add-on in that add-on type. It also fixes a display issue that's been around awhile with clear: both in the admin pages.

This is mainly a temporary fix until the hopeful Dev CP revamp when selecting categories will be way better.

This SQL will need to be run:

ALTER TABLE `tags` CHANGE `application_id` `application_id` INT( 11 ) UNSIGNED default NULL;
UPDATE tags SET application_id=NULL WHERE addontype_id=4;

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 296886 [details] [diff] [review]
patch

The patch is good but we need additional code.  If you set a category to "all" and then browse the categories for the extension the category no longer shows up (AddonsController::_browseCategories()).  Also, if I try to submit a new search engine, on step 2 of the submission it says "No categories available for this add-on type."

Comment 3

[Justin Scott [:fligtar]]

Attachment: patch, v2

Fixes above issues.

Comment 4

[Justin Scott [:fligtar]]

Checked in. The SQL in comment 1 will need to be run when this is pushed.

Comment 5

[Justin Scott [:fligtar]]

This is live.