Closed Bug 408525 Opened 15 years ago Closed 15 years ago

AMO doesn't allow search engines to be placed into categories

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: baz, Assigned: fligtar)

References

Details

Attachments

(1 file, 1 obsolete file)

I've created search engines categories as specified in bug 396741. Unfortunately, the addon edit admin UI complains that you can't put search engines into categories.
Blocks: 372852
Assignee: nobody → fligtar
Attached patch patch (obsolete) — Splinter Review
This patch adds an "All" option for the applications field of categories. If tags.application_id is NULL, it will be available to every add-on in that add-on type. It also fixes a display issue that's been around awhile with clear: both in the admin pages.

This is mainly a temporary fix until the hopeful Dev CP revamp when selecting categories will be way better.

This SQL will need to be run:

ALTER TABLE `tags` CHANGE `application_id` `application_id` INT( 11 ) UNSIGNED default NULL;
UPDATE tags SET application_id=NULL WHERE addontype_id=4;
Attachment #296886 - Flags: review?(clouserw)
Comment on attachment 296886 [details] [diff] [review]
patch

The patch is good but we need additional code.  If you set a category to "all" and then browse the categories for the extension the category no longer shows up (AddonsController::_browseCategories()).  Also, if I try to submit a new search engine, on step 2 of the submission it says "No categories available for this add-on type."
Attachment #296886 - Flags: review?(clouserw) → review-
Attached patch patch, v2Splinter Review
Fixes above issues.
Attachment #296886 - Attachment is obsolete: true
Attachment #297598 - Flags: review?(clouserw)
Attachment #297598 - Flags: review?(clouserw) → review+
Checked in. The SQL in comment 1 will need to be run when this is pushed.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: push-needed
Resolution: --- → FIXED
This is live.
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.