408533 - Incremental find in the Find bar should not jump to the next match

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

"- Trying to fix the fact that incremental search should start again from the
beginning of the current range, rather than skipping to the next word"

STR:

1. Visit URL above
2. Cmd-F
3. Type Cami
4. Observe selection
5. Type no
6. Observe selection

ER: First instance of "Camino" on the page is (partially/wholly) selected in both step 4 and step 6

AR: First instance of "Camino" on the page is selected in step 4, second instance is selected in step 6.

Comment 2

[Stuart Morgan]

Attachment: fix

Collapses the selection range just before searching, so that the search will extend in place as expected. As a side-effect, a search with no matches will clear the current selection, but I view that as reasonable (if not improved) behavior.

I also chained the initial search method through the find-again method so that I didn't need to duplicate the code.

Comment 3

[Mark Mentovai]

Comment on attachment 299517 [details] [diff] [review]
fix

>+    //nsCOMPtr<nsIDOMWindow> domWindow = [self contentWindow];
>+    nsCOMPtr<nsIDOMWindow> domWindow = [self focussedDOMWindow];

Get rid of the commented-out line, or give a comment explaining why it's there but commented out.

>+      domWindow->GetSelection(getter_AddRefs(selection));
>+      if (selection)
>+        selection->CollapseToStart();


What BS that nsIDOMWindow::GetSelection's nsresult return value can't be relied upon.

[s]r=me

Comment 4

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH with the cruft commented line removed.