Closed
Bug 408596
Opened 17 years ago
Closed 17 years ago
Preferences dialog Textboxes do not have labels associated with them
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: MarcoZ, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [cz-0.9.80])
Attachments
(1 file, 1 obsolete file)
1.01 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
As discussed on IRC, the textboxes in the ChatZilla Preferences dialog pages do not have labels associated with them. Also, some of the groupings may have their labels missing.
Assignee | ||
Comment 1•17 years ago
|
||
Yay for autogenerated stuff :-).
Attachment #293524 -
Flags: review?(silver)
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 293524 [details] [diff] [review] Patch Marco, could you test this?
Attachment #293524 -
Flags: review?(marco.zehe)
Comment 3•17 years ago
|
||
Comment on attachment 293524 [details] [diff] [review] Patch >+ // For accessibility: >+ if (label) >+ { >+ this.edit.id = this.name; Nice try, but this isn't unique. The prefname is the name with respect to the object in question (i.e. what you pass to its PrefManager).
Attachment #293524 -
Flags: review?(silver) → review-
Reporter | ||
Comment 4•17 years ago
|
||
Comment on attachment 293524 [details] [diff] [review] Patch Good for the effect this has on accessibility.
Attachment #293524 -
Flags: review?(marco.zehe) → review+
Reporter | ||
Comment 5•17 years ago
|
||
Gijs, are you going to fix comment #3 soon? Other than bug 404881, this is currently the only a11y issue with ChatZilla.
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #5) > Gijs, are you going to fix comment #3 soon? Other than bug 404881, this is > currently the only a11y issue with ChatZilla. > I just got back from holidays (well, I did volunteer work all of the time, so not sure how much that'd count as such) - hence why I didn't do anything. I'll try to get it fixed asap. Might be a few days, I'm busy getting back home...
Assignee | ||
Comment 7•17 years ago
|
||
This should be a bit better. :-)
Attachment #293524 -
Attachment is obsolete: true
Attachment #295520 -
Flags: review?(silver)
Comment 8•17 years ago
|
||
Comment on attachment 295520 [details] [diff] [review] Better patch Perhaps a longer comment would be better, e.g.: // Associate textbox with label for accessibility.
Attachment #295520 -
Flags: review?(silver) → review+
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•17 years ago
|
||
Checking in mozilla/extensions/irc/xul/content/config.js; /cvsroot/mozilla/extensions/irc/xul/content/config.js,v <-- config.js new revision: 1.12; previous revision: 1.11 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.80]
You need to log in
before you can comment on or make changes to this bug.
Description
•