408596 - Preferences dialog Textboxes do not have labels associated with them

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Marco Zehe (:MarcoZ)]

As discussed on IRC, the textboxes in the ChatZilla Preferences dialog pages do not have labels associated with them. Also, some of the groupings may have their labels missing.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Yay for autogenerated stuff :-).

Comment 2

[:Gijs (he/him)]

Comment on attachment 293524 [details] [diff] [review]
Patch

Marco, could you test this?

Comment 3

[James Ross]

Comment on attachment 293524 [details] [diff] [review]
Patch

>+        // For accessibility:
>+        if (label)
>+        {
>+            this.edit.id = this.name;

Nice try, but this isn't unique. The prefname is the name with respect to the object in question (i.e. what you pass to its PrefManager).

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 293524 [details] [diff] [review]
Patch

Good for the effect this has on accessibility.

Comment 5

[Marco Zehe (:MarcoZ)]

Gijs, are you going to fix comment #3 soon? Other than bug 404881, this is currently the only a11y issue with ChatZilla.

Comment 6

[:Gijs (he/him)]

(In reply to comment #5)
> Gijs, are you going to fix comment #3 soon? Other than bug 404881, this is
> currently the only a11y issue with ChatZilla.
> 

I just got back from holidays (well, I did volunteer work all of the time, so not sure how much that'd count as such) - hence why I didn't do anything. I'll try to get it fixed asap. Might be a few days, I'm busy getting back home...

Comment 7

[:Gijs (he/him)]

Attachment: Better patch

This should be a bit better. :-)

Comment 8

[James Ross]

Comment on attachment 295520 [details] [diff] [review]
Better patch

Perhaps a longer comment would be better, e.g.: // Associate textbox with label for accessibility.

Comment 9

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/config.js;
/cvsroot/mozilla/extensions/irc/xul/content/config.js,v  <--  config.js
new revision: 1.12; previous revision: 1.11
done