408666 - Moving nsWindowCreator2 interface patch

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: gtkmozmebed nsWindowCreator2 interface

Moving nsWindowCreator2 interface patch from Bug 408238

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

What's the reason to implement nsIWindowCreator2 ? You just fall back to nsIWindowCreator in the implementation, but nsWindowWatcher will do the fallback to nsIWindowWatcher itself if nsIWindowWatcher2 isn't provided.

Comment 2

[Oleg Romashin (:romaxa)]

> but nsWindowWatcher will do the fallback to nsIWindowWatcher itself if nsIWindowWatcher2 isn't provided.

That fallback does not work for some test cases.

Probably it is better to fix in nsWindowWatcher, I have to check implementation and probably will provide better testcase and patch for windowwatcher too.

Comment 3

[Oleg Romashin (:romaxa)]

gtkmozembed windowCreator does not work properly with xpinstallConfirm.xul dialog...

try to open any xpi url with TestGtkEmbed... it hang on ShowAsModal call.

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Workaround fix for xpinstaller/ext.manager xul dialogs

This patch will fix proper displaying of xul windows in embedding configuration.

I don't have right proposal how and where it should be fixed, but default nsWindowCreator2 fallback does not work for xul windows which requires context flags....

Should we add nsIXULWindow interface to embed window?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I don't think we will land that.