Using glib-genmarshal for generation gtkmozembedmarshal*

RESOLVED FIXED in mozilla1.9beta3

Status

Core Graveyard
Embedding: GTK Widget
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9beta3
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 293520 [details] [diff] [review]
Bugfix

gtkmozembed should use glib-genmarshal for auto-generation garbage files gtkmozembedmarshal.c and gtkmozembedmarshal.h
(Assignee)

Updated

10 years ago
Attachment #293520 - Flags: review?(benjamin)

Comment 1

10 years ago
Comment on attachment 293520 [details] [diff] [review]
Bugfix

benjamin@smedbergs.us, does this look okay?
(Assignee)

Comment 2

10 years ago
Probably gtkmozembedmarshal.c gtkmozembedmarshal.h should be deleted, because is will confuse gtkmozembedmarshal.c make rule

Comment 3

10 years ago
Comment on attachment 293520 [details] [diff] [review]
Bugfix

>+$(MARSHAL_FILE).h: $(MARSHAL_FILE).list
>+	glib-genmarshal --prefix=$(MARSHAL_PREFIX) $(srcdir)/$(MARSHAL_FILE).list --skip-source --header > $(MARSHAL_FILE).h

Use > $@ instead of > $(MARSHAL_FILE).h, and the same below

And yes, you do need to remove the checked-in marshal file as well.
Attachment #293520 - Flags: review?(benjamin) → review+
Assignee: nobody → romaxa
(Assignee)

Comment 4

10 years ago
Created attachment 296799 [details] [diff] [review]
Fixed Use > $@ instead of > $(MARSHAL_FILE).*
Attachment #293520 - Attachment is obsolete: true
Attachment #296799 - Flags: approval1.9?

Updated

10 years ago
Attachment #296799 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in embedding/browser/gtk/src/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/src/Makefile.in,v  <--  Makefile.in
new revision: 1.76; previous revision: 1.75
done
Removing embedding/browser/gtk/src/gtkmozembedmarshal.c;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembedmarshal.c,v  <--  gtkmozembedmarshal.c
new revision: delete; previous revision: 1.6
done
Removing embedding/browser/gtk/src/gtkmozembedmarshal.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembedmarshal.h,v  <--  gtkmozembedmarshal.h
new revision: delete; previous revision: 1.6
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11

Updated

10 years ago
Depends on: 417651
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.