417651 - gtkmozembed2.cpp compile fails due to missing gtkmozembedmarshal.h

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

I just did a fresh clobber on my Solaris box, and the compile failed.

Building deps for /export/home/dolske/ff/ff-trunk/mozilla/embedding/browser/
    gtk/src/EmbedProgress.cpp using Sun Studio CC
"/export/home/dolske/ff/ff-trunk/mozilla/embedding/browser/gtk/src/
    gtkmozembed2.cpp", line 51: Error: Could not open include file
    "gtkmozembedmarshal.h".
1 Error(s) detected.
gmake[5]: *** [gtkmozembed2.o] Error 1

Adding an explicit dependancy in the Makefile fixes this. Dunno if there's a more proper way to express it.

Comment 1

[Benjamin Smedberg]

Comment on attachment 303439 [details] [diff] [review]
Patch v.1

I'm not sure how this could work: the *object* should depend, not the source file:

gtkmozembed2.$(OBJ_SUFFIX): $(MARSHAL_FILE).h

Comment 2

[Justin Dolske [:Dolske]]

Hmm, not sure what was happening (although this patch definitely fixed it for me!), but (1) my Solaris box seems to have decided to stop building for other reasons and (2) no one else seems to be be reporting Solaris bustage, but I'm just going to close this as INVALID.

Is someone else finds this bug by way of searching for the error, please reopen.