Default buttons should be painted as such

RESOLVED FIXED in mozilla1.9beta3

Status

()

Core
Widget: Gtk
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Ian Spence, Assigned: Ian Spence)

Tracking

Trunk
mozilla1.9beta3
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 293545 [details] [diff] [review]
Paints a default button with "buttondefault"

In GTK default buttons are painted differently. In Firefox they are not, even though we have a way in the code to tell if it's a default button.

Attached is an extremely lengthy patch that addresses the problem
Attachment #293545 - Flags: superreview?(roc)
Attachment #293545 - Flags: review?(roc)
Comment on attachment 293545 [details] [diff] [review]
Paints a default button with "buttondefault"

sweet. Glad you were joking :-)
Attachment #293545 - Flags: superreview?(roc)
Attachment #293545 - Flags: superreview+
Attachment #293545 - Flags: review?(roc)
Attachment #293545 - Flags: review+
Attachment #293545 - Flags: approval1.9?
Comment on attachment 293545 [details] [diff] [review]
Paints a default button with "buttondefault"

a=beltzner for 1.9
Attachment #293545 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11

Updated

10 years ago
Depends on: 408853
You need to log in before you can comment on or make changes to this bug.