Closed
Bug 408705
Opened 17 years ago
Closed 17 years ago
Default buttons should be painted as such
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: ispence, Assigned: ispence)
References
Details
Attachments
(1 file)
1.34 KB,
patch
|
roc
:
review+
roc
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
In GTK default buttons are painted differently. In Firefox they are not, even though we have a way in the code to tell if it's a default button.
Attached is an extremely lengthy patch that addresses the problem
Attachment #293545 -
Flags: superreview?(roc)
Attachment #293545 -
Flags: review?(roc)
Comment on attachment 293545 [details] [diff] [review]
Paints a default button with "buttondefault"
sweet. Glad you were joking :-)
Attachment #293545 -
Flags: superreview?(roc)
Attachment #293545 -
Flags: superreview+
Attachment #293545 -
Flags: review?(roc)
Attachment #293545 -
Flags: review+
Updated•17 years ago
|
Attachment #293545 -
Flags: approval1.9?
Comment 2•17 years ago
|
||
Comment on attachment 293545 [details] [diff] [review]
Paints a default button with "buttondefault"
a=beltzner for 1.9
Attachment #293545 -
Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v <-- gtk2drawing.c
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
You need to log in
before you can comment on or make changes to this bug.
Description
•