408853 - no borders for a lot of ok/default buttons

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: screenshot from thunderbird

On trunk, a lot of buttons suddenly do not paint as buttons, and without borders. I believe this is due to bug 408705.

The screenshot is for thunderbird, but there are similar problems in firefox.

Comment 1

[Ian Spence]

I'm only able to replicate this on two themes, so I'm gonna look at what makes them so special

Comment 2

[Ian Spence]

I just messed up my understanding of the use of "buttondefault". It isn't a replacement to "button", it's in addition to. I'll have a patch sometime tonight, I kinda mixed this fix with another issue I was working on so I can't do a diff right now

Comment 3

[Ian Spence]

Attachment: Fixes the painting of default buttons

Paints the default button so it works correctly in all styles

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 293757 [details] [diff] [review]
Fixes the painting of default buttons

thanks for the prompt action

Comment 5

[Reed Loden [:reed]]

Comment on attachment 293757 [details] [diff] [review]
Fixes the painting of default buttons

Fix regression with default buttons.

Comment 6

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.57; previous revision: 1.56
done

Comment 7

[Magnus Melin [:mkmelin]]

VERIFIED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007122005 Thunderbird/3.0a1pre ID:2007122005