408938 - Include bookmarks toolbar folder in bookmarks menu

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[John]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121805 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121805 Minefield/3.0b3pre

I mean, it would match IE behavior, old FF1+FF2 behavior, kind of Opera behavior (it doesn't have a manageable folder for it like Links in IE or Bookmarks Toolbar Folder in old FF).

I don't see how it's intuitive to have some bookmarks or folders only accesible by ctrl+b or ctrl+shift+b. 

I can see how it's redundant to have Bookmarks Toolbar out on the screen and Bookmarks Menu, but is 1 more entry on Bookmarks Menu going to clutter anything? Makes for a lot more clarity I think.

Reproducible: Always

Steps to Reproduce:
1. Look for Bookmarks Toolbar Folder in Bookmarks Menu
2.
3.
Actual Results:  
Don't see it as I do in old Firefox or IE.

Expected Results:  
See it. Why not if I can see it in the Bookmarks Sidebar?

Comment 1

[(not reading, please use [e-mail] instead)]

confirming, but this is a dup.

Comment 2

[John]

https://bugzilla.mozilla.org/show_bug.cgi?id=405487
It's similar...

I'm requesting that the Menu be the "root" folder, while Toolbar and Unfiled are under this umbrella.

As said before, this would be familiar to older FF users as well as IE+"Links".

Comment 3

[Hideo Oshima]

(In reply to comment #1)
> confirming, but this is a dup.
 
I can't find the dup bug.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Let's not regress accessibility unless we have a good reason, yeah. If it's trivial to add this back in, let's do so.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

This item should get the bookmarks toolbar icon that we will also be using in the library window.

Comment 7

[Kris Silver]

For Firefox's out there with the bookmarks toolbar not shown, many users will think they've lost the bookmarks toolbar items altogether when they can't access them in the bookmarks drop down.  

For the few beyond novice users whom would remedy, they would either be forced to show the toolbar, sidebar, or edit folders in Places (caused me to crash once).  All bookmarks folder items should be accessible in the bookmarks drop-down, this includes bookmark toolbar folder, and smart bookmarks, for which the same cons I've noted apply.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

How about this organization:

Bookmark this Page
Subscribe to this Page...
Bookmark all Tabs...
-------------------------
Show All Bookmarks...
Bookmarks Toolbar    >
-------------------------
[user's bookmarks]

Right now show all is grouped with the actions of bookmarking pages, which doesn't seem to make a whole lot of sense.  If we add this splitter, we should also put one before "Show All History."

Comment 9

[Kris Silver]

Valid point about separating Show All Bookmarks, after all it does need more emphasis in light of changes.  Bookmarks Toolbar is just a folder, so I think down one, per below is most logical:


Bookmark this Page
Subscribe to this Page
Bookmark All Tabs
-----------------------
Show All Bookmarks
-----------------------             
Bookmarks Toolbar           (folders, bookmarks)
Mozilla Firefox       

Comment 10

[Asaf Romano (gone)]

Attachment: patch

Comment 11

[Dietrich Ayala (:dietrich)]

Comment on attachment 308533 [details] [diff] [review]
patch

r=me

Comment 12

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-menubar.inc 1.149
mozilla/browser/base/content/browser.js 1.999

Comment 13

[Andrés Delfino]

Please, revert this.

Having the Bookmarks toolbar in the Bookmarks menu is not intuitive. If I don't use the toolbar at all, I get an irrelevant option which doesn't have any sense there anyway.

If users hide the Bookmarks toolbar it's their problem. Bookmarks _toolbar_ hello? 

Dind't try Internet Explorer and Opera behavior on this, but if it's the mentioned here, it's broken, as Firefox behavior is broken now.

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

This is an accessibility issue, if a vision impaired user is accessing Firefox with a screen reader, they need to be able to navigate to the bookmarks located in the bookmarks toolbar.

Comment 15

[Kris Silver]

Good point Alex, since Firefox 1.0 four years ago, very few have complained about the bookmarks toolbar showing in the dropdown, the majority are used to accessing it, like ALL bookmarks in the dropdown, and should be able to in one place.  Deleting the folder should be an option, though not losing smart bookmarks, or being able to bring them back easily should be easy.

A good proposal on the Mozillazine forums which would further address your personal annoyance Andres, is not having it as a folder at all. 

Don't force referring to a toolbar many users don't have, much like still currently forcing a user to go to another window for unfiled bookmarks, have a link to search at least.  Instead have something like Opera has, no bookmarks toolbar folder, but instead an option for bookmarks of "Show on Toolbar".  Much more intuitive, doesn't force toolbar usage and terminology on those whom don't use it, and is one less folder, users shouldn't have to have to keep any folders.  Seems a much better, simpler system to aid usability and choice.

Comment 16

[(mostly gone) XtC4UaLL [:xtc4uall]]

FYI: i filed Bug 422829 for reverting/optimizing the introduced behovior ...

Comment 17

[John]

I hate Opera's style on the favorites bar...

Comment 18

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031704 Minefield/3.0b5pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031704 Minefield/3.0b5pre

Comment 19

[Asko Tontti]

It seems this change causes hangs on MacOS X 10.5 (infinite recursive menus), see bug 400291 comments 58 and 59.

Comment 20

[Christiaan Hofman]

> It seems this change causes hangs on MacOS X 10.5 (infinite recursive menus),
> see bug 400291 comments 58 and 59.

This change indeed triggers bug 400291, but that bug is also partially caused by two other bugs (one by Apple and one by Mozilla). Anyway, infinite recursive menus should never be created, but they currently are. 

To add to this bug, there should be a separator between the Organize Bookmarks item and the Bookmarks Toolbar item. 

Comment 21

[Kris Silver]

I hope this remains, another thing to consider is; like bookmarks in the sidebar, unfiled bookmarks should be accessible in the drop down, as the only item that's currently not.  This forces behaviour, something Fx advocates not doing, which makes users uncomfortable, many imo won't know where to find the unfiled bookmarks at all if it's not in the bookmarks dropdown where for years now they've rightly become used to being able to access all bookmarks.

Even if it's just a "Unfiled Bookmarks" folder in the smart bookmarks folder, which shows ten items and has a "Search" entry within, linking to Places, this would suffice and make things much clearer to users.

Comment 22

[Luke Iliffe (Harlequin99)]

Are there any plans to separate the "Organize Bookmarks..." entry with an additional separator below as suggested in comment 9? 

I find myself repeatedly having to take an extra second to correctly locate the orgainze menu item with the mouse, or mistakenly hitting the entries above or below instead. Having this function separated would make it for me quicker to navigate this menu and result in fewer mistaken actions. 

Comment 23

[Christiaan Hofman]

I've added a new separate bug on the missing separator, Bug 427558. 

Comment 24

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv