40898 - Cancel button in Edit categories dialog should undo the changes

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Search, defect, P2)

Description

[Blake Ross]

Build ID: 2000052808

In the Customize Search dialog (Sidebar > Search tab > Customize...), there 
appears to be point to the Cancel button.  Any change you make in the dialog is 
immediately reflected in the actual Search tab of the Sidebar (you can see this 
as you make changes), and pressing Cancel doesn't undo these changes, it merely 
closes the dialog.  In this sense, it really functions in the same way as OK.  
This dialog could just include an OK button, but that (IMHO) is the cheap way 
out.  What we really should be doing is not actually making the changes until 
the user hits OK; otherwise, if he presses cancel, the dialog should close and 
no changes be made.

Comment 1

[Blake Ross]

er, in my comment: "there appears to be point to the Cancel button", I obviously 
intended to say "there appears to be _no_ point to the Cancel button"

sorry

Comment 2

[timeless]

*** Bug 40927 has been marked as a duplicate of this bug. ***

Comment 3

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is a Netscape beta stopper.

Comment 4

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 5

[matt]

Blake, german,

What would you think about me just taking out the cancel button in this dialog? 
 this is going to be more work then i thought and i've just been dumped with 
some other very high priority stuff.   I think this dialog is not used that 
offen.   if you want to recover then you can go though the items again with 
little effort.  Ultimately I don't think it's high on the scale to have a cancel 
button but i want your opinion.

Comment 6

[Blake Ross]

Matt, mind if I take this?  I think I've had the fix in my tree for awhile.

Comment 7

[matt]

do i mind...hell i'll pay you to take it.

Comment 8

[chris hofmann]

this could come after 0.8.1 and very early in 0.9 and
we would all still live happily ever after, right?

Comment 9

[Blake Ross]

I lost the patch for this, unfortunately.

Comment 10

[Blake Ross]

-> default owner

Comment 11

[Samir Gehani]

``In the Customize Search dialog (Sidebar > Search tab > Customize...)''
Huh?  Can't find this button.

Comment 12

[Blake Ross]

You have to turn on Advanced search, and the choice is in the dropdown list next
to "within" in the Search tab.

Yes, this was voted "obscurest dialog in Mozilla" ;-)

Comment 13

[Samir Gehani]

I suspected that but failed to test the cancel button before closing.  Thanks
for clarifying.

Comment 14

[Samir Gehani]

Attachment: Only display an OK button.

Comment 15

[Samir Gehani]

morse, please r.
blake, please sr.

Comment 16

[Stephen P. Morse]

Comment on attachment 68029 [details] [diff] [review]
Only display an OK button.

r=morse

Comment 17

[Blake Ross]

sr=blake...can this bug remain open for a real cancel button?

Comment 18

[Samir Gehani]

Sure.  Leaving bug open for a more complete fix: cancel button that actually
does cancel the users actions.

Checked in this fix.

Comment 19

[Erich 'Ricky' Iseli]

Shouldn't this be marked FIXED?

Comment 20

[Erich 'Ricky' Iseli]

Please ignore my stupid comment above. Changed Summary in order to reflect the
current problem. Previous summary was: "Cancel button is useless in Customize
Search dialog", but it doesn't make any more sense, since the cancel button has
been (temporarly) removed.

Comment 21

[Robert Kaiser]

No activity -> incomplete.