409096 - Some suggestions to improve the new Agenda Pane

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Berend Cornelius]

In bug 389854 Christian made the following suggestions to improve the new agenda-pane:
- Allow customization of the Agenda Pane
- Allow multi selection of events
- Improve Context Menu
- Improve UI of All Day Events

- It might make sense to split "Next Week" into two sections:
  - "This Week", and
  - "Next Week"

Assume today is Monday. Events which scheduled for the day after tomorrow, in
that case Wednesday, would be listed in the section "Next Week". Which is
wrong. 

From my point of view it would make sense to list this event in a section
called "This week". For this case "This Week" would contain all events from
Wednesday till Sunday. "Next week" would contain only  events scheduled for the
upcoming week.

Comment 1

[Berend Cornelius]

Accepting issue. The least thing that we should do before the 0.8 release is to change the label of the third period.

Comment 2

[Berend Cornelius]

Attachment: patch #1

This patch delivers the string for the "This Week" period. It does not yet fully resolve the issue and should therefor only be a first step

Comment 3

[Stefan Sitter [:ssitter]]

My opinion: The section name should be changed back to it's previous name to avoid the introduction of another section that wastes more valuable screen space.

I guess the following enhancements might be useful too: 
Display the number of entries next to the section name, e.g. "Tomorrow (4)". 
Difference between sections with entries and without entries visually. Currently one need to expand the section to check if it contains items or not. E.g remove the [+] box or format the name non-bold. Or the section could be hidden entirely if no entries are present.

Comment 4

[Michael Büttner (no reviews TFN)]

Comment on attachment 297768 [details] [diff] [review]
patch #1

> <!ENTITY calendar.nextweek.button.label       "Next Week">
>+<!ENTITY calendar.thisweek.button.label       "This Week">
In case you don't need 'nextweek.button.label' any longer, there's not need to keep it. Apart from that, the patch looks fine to me. r=mickey.

Comment 5

[Christian Jansen]

Comment on attachment 297768 [details] [diff] [review]
patch #1

I approve the resource, but we need to fill it with functionality.

"This Week" = show all event  from next day after tomorrow till Sunday.

"Next Week" = Everything in the upcoming week.

Comment 6

[Berend Cornelius]

Attachment: (checked in) patch #2

Due to Christian's comment #5 I shortened the patch so that only the resource file remains within
patch checked in on trunk and MOZILLA_1_8_BRANCH

Comment 7

[Sebastian Schwieger]

(In reply to comment #5)
> "This Week" = show all event  from next day after tomorrow till Sunday.
>
Christian: I think this needs to be taken from the prefs. Not everywhere Sunday is the last day of the week.

Comment 8

[Pete Riley]

I also prefer the original "Soon" section instead of This Week / Next Week.  The Soon section was nice because it always showed the events from the day after tomorrow to six days after that.  No more, no less.

With This Week / Next Week, you have to look at fourteen days of events on Mondays, but by Sunday you see no more than eight days of events.  Also, there would never be anything in the "This Week" section on Saturdays or Sundays (because covered by Today/Tomorrow).  Also, on Sundays, the events in "Next Week" would not include Monday because that is Tomorrow.  I think that it's all too weird.  Also, as Stefan wrote, the "Next Week" section would waste an entire row of screen space.

I know that the wiki suggests that we might eventually be able to disable the "Next Week" section to avoid some of these problems, but then by Sunday only Today and Tomorrow would contain events, and now there is not enough information (can't see any future events except for tomorrow).


> Or the section could be hidden entirely
> if no entries are present.

+1 for this proposal from Stefan.  I think that this behavior would also be nice in the task list (e.g. the "Overdue" section might often be empty).

Comment 9

[Pete Riley]

Maybe these don't belong in this bug, but I'll mention them:

1) Events with long titles don't have ellipses (...).  However, this works correctly for allday events.

2) Tooltips are not working at all.

Comment 11

[Stefan Sitter [:ssitter]]

See Bug 413879 and Bug 412739 for the confusion raised by the (incorrect) renaming from "Soon" to "Next Week".

Comment 12

[Sven Giermann]

As this still seems to be in 'decision' phase and the title is "Some suggestions to improve the new Agenda Pane", I post the following here:

* All day events are shown without date in "Next week" section --> please fix this

* I would like to have this week's and next week's events in the agenda
  a) implement both sections: "This week", "Next week"
  b) re-implement "Soon" section, but make the number of days configurable

I would agree with Stefan and Pete, that sections without entries should be hidden. If you do not want this for sections, that do not contain entries, because no events exist, it should at least be done to sections that are logically always empty because of the other sections (see comment #8).

Comment 13

[Pete Riley]

(In reply to comment #12)
> * All day events are shown without date in "Next week" section --> please fix
> this

To save vertical space in the "Next Week" or "Soon" section, maybe only the first event of each day should have the date (regardless if it's an allday or not).

Comment 14

[Simon Paquet [:sipaq]]

Berend, what needs to be done here? Is this really still wanted0.8?

Comment 15

[Berend Cornelius]

patches have become obsolete as we agreed to take "soon" as agenda-header.

Comment 16

[Martin Schröder [:mschroeder]]

Changing from WFM to FIXED because there exists a checked in patch.