Closed Bug 40911 Opened 25 years ago Closed 25 years ago

Drag and drop text in the same window tries to load it as a URL

Categories

(Core :: DOM: Selection, defect, P3)

Product:
Core
Component:
DOM: Selection
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jlarsen, Assigned: Brade)

References

Details

(Whiteboard: [nsbeta2+][6/15][dogfood-]have fix)

If I select non input box text, and try and drag it anywhere it tries to put the text into the url bar and load url. While this may be intentional its a bit annoying if it happends accidently.. but not a big deal.. marking an enhancement. (I have this weird habit of highlighting text as I go.. (don't ask) and occasionally accidently drag some of it, which causing this problem... but then again.. thats just me :)
I think this is more serious than "enhancement". See also bug 36867.
Severity: enhancement → normal
I have a fix for this bug; we should disable a "hacky" feature which someone added to the browser d&d code (dropping any plain text in the window causes it to attempt to load that url (even though it may not be a url)). Reassign to myself.
Assignee: mjudge → brade
Component: Selection → Browser-General
Keywords: nsbeta2
Whiteboard: have fix
I hope by `disable', you really mean either `remove' or `properly reimplement' ...
Keywords: dogfood
Target Milestone: --- → M16
kathy, what do you plan on doing with text/unicode dropped on navigator? parsing it yourself? if you just don't allow text/unicode drops, lots of functionality will be lost (url from finder or other applications for starters). this also doesn't fix the case where you drag a link and drop it on the same window because it contains text/unicode w/ a valid url in it and would pass whatever tests you try to filter out... am i just confused here?
Putting on [nsbeta2+][6/15] radar. This bug is a bit confusing though. We assume is about dropping content from a page onto the same page.
Component: Browser-General → Selection
QA Contact: elig → sujay
Whiteboard: have fix → [nsbeta2+][6/15]have fix
Two bugs here: 1. If the destination window is the same as the source window, the drag should have no effect -- on Mac, it should show the 'zoom back' animation to show that it was refused. 2. We should verify that the dragged text actually looks like a URL before trying to load it as one. My Mac just crashed in OT when it tried to load some random text as a URL.
Summary: Drag text opens new url → Drag and drop text in the same window tries to load it as a URL
(1) what about dragging a link to the sidebar or the personal toolbar? that should be allowed (2) agreed. file a new bug against don's team.
Putting on [dogfood-] radar since [nsbeta2+] already indicated.
Whiteboard: [nsbeta2+][6/15]have fix → [nsbeta2+][6/15][dogfood-]have fix
Should we allow dropping into a form within the same window???? seems like something to allow.
Dropping to form field should definitely be allowed. D&D within and between form fields should work, too. (This would, BTW, put Mozilla ahead the competition in terms of form D&D.)
*** Bug 41379 has been marked as a duplicate of this bug. ***
I have checked in a fix for this issue which should solve the problem in most cases. If people are still seeing problems, please file new bugs (with only one issue each). My fix is a partial attempt to fix issue #2 that Simon raised. Issue #1 can be done properly but not at this time (the api doesn't allow it). There is a separate bug assigned to pinkerton@netscape.com which is blocking #1. Resolving this bug as fixed.
Status: NEW → RESOLVED
Closed: 25 years ago
OS: other → All
Hardware: PC → All
Resolution: --- → FIXED
I'm not seeing this fixed in windows 98 2000060814 If not still fixed in tommorrows build, will reopen.
Could you type here what url/page your are trying to drag from and what actual text or objects is in the selection?
Well it seems to work in 2000060821 (which is in the m17 tree as 0814 was m16 tree, which didn't work) You might want to check to see if your code got into the m16 or is it too late for that? Doesn't really matter though, its fixed anyways, marking as verified.
Status: RESOLVED → VERIFIED
I'm pretty sure this didn't make it into the M16 build; I'll reset milestone so people won't be confused.
Target Milestone: M16 → M17
This fix only seems to work for muliple word highlight/drag if I highlight just one word and drag it loads it as a url!!!. This is not a regression, saw this right after this was fixed but way to busy to report it sorry :(
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Please file the previous comment as a new bug (dropping a single word in the same window causes it to load the word as a url). Someone else should fix that issue since it's a browser-specific feature. (Feel free to cc me on that bug.) Note: What is the expected behavior when a single word is dragged from one browser window to another? Please describe that in the new bug as well.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
verified in 7/5 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.