409260 - msys cvs 1.11.22 has issues

Status: RESOLVED WONTFIX

(Firefox Build System :: MozillaBuild, task)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Using the MozillaBuild 1.2 RC I can't checkin with CVS. Found when trying to check in the fix for bug 409114, here was my output:

  Ben@SOLACEWIN ~/src/mozilla/trunk/mozilla/tools/build-environment/win32
  $ cvs ci -m "New build stuff"
  cvs commit: nothing known about `packageit.sh'
  cvs commit: nothing known about `profile-sshagent.sh'
  cvs commit: nothing known about `start-msvc6.bat'
  cvs commit: nothing known about `start-msvc71.bat'
  cvs commit: nothing known about `start-msvc8.bat'
  cvs [commit aborted]: correct above errors first!

  Ben@SOLACEWIN ~/src/mozilla/trunk/mozilla/tools/build-environment/win32
  $ cvs st | grep File: | grep -v Up-to-date
  File: packageit.sh      Status: Locally Modified
  File: profile-sshagent.sh       Status: Locally Added
  File: start-msvc6.bat   Status: Locally Modified
  File: start-msvc71.bat  Status: Locally Modified
  File: start-msvc8.bat   Status: Locally Modified

Comment 1

[(not currently active) Ted Mielczarek]

bsmedberg says bug 373304 updated CVS to 1.11.22, but due to a packaging problem, it wasn't included in MozillaBuild 1.1.  We picked it up in MozillaBuild 1.2 because we wound up fixing the packaging problem.

This also seems to be causing a bug whereby multiple recursive copies of the source tree are checked out (under mozilla/build/autoconf/) during make -f client.mk checkout.  I checked, and using /bin/cvs.exe (which is 1.11) instead of /local/bin/cvs.exe (1.11.22) makes both of these problems go away.  :-(

Comment 2

[(not currently active) Ted Mielczarek]

Apparently this has been reported before:
http://readlist.com/lists/lists.sourceforge.net/mingw-msys/0/670.html

I'm just going to roll back to 1.11 for 1.2, and we'll look into this for 1.3.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: stop building cvs 1.11.22 [checked in]

Not really a satisfying option, but MozillaBuild 1.2 is blocking beta3, and we're no worse off shipping 1.11 again than we are with MozillaBuild 1.1.  I don't know that there's a really easy answer to this, it might fix itself if we update all our msys packages or something, but that's out of scope for 1.2.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 294150 [details] [diff] [review]
stop building cvs 1.11.22 [checked in]

This is checked in.  Leaving this bug open for a better solution for MozillaBuild 1.3.

Comment 5

[Alfred Kayser]

Can we have a cvs version that also support pserver;proxy ?

Comment 6

[(not currently active) Ted Mielczarek]

Do you know what version that would be?  I would like to get a newer CVS into MozillaBuild, just that 1.11.22 from msys had a lot of bugs.

Comment 7

[Alfred Kayser]

See http://ximbiot.com/cvs/wiki/CVS%20FAQ:
    As of CVS release 1.12.7, CVS supports connecting via HTTP proxies using "connection options" with a syntax like::
  :pserver;proxy=<proxyserver>;proxyport=<portnum>:

Not sure, how and when this is taken up in mingw...

Comment 8

[(not currently active) Ted Mielczarek]

We'll take another swing at this when we get around to MozillaBuild 1.3.

Comment 9

[Axel Hecht [:Pike]]

MozillaBuild's cvs can't do user:password check-outs either, which breaks anonymous checkouts of l10n from client.mk, which uses anonymous:[e-mail] :-(.

Comment 10

[(not currently active) Ted Mielczarek]

Don't think I care enough about CVS anymore for this to matter in our glorious future of hg.