Make ChatZilla optional in SeaMonkey NSIS installer

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
Installer
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Robert Kaiser, Assigned: wladow)

Tracking

Trunk
seamonkey2.0a1
x86
Windows XP
Dependency tree / graph
Bug Flags:
blocking-seamonkey2.0a1 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
ChatZilla currently sits in nonlocalized\extensions\ in the NSIS installer but should be optional (installed by default).
(Reporter)

Comment 1

10 years ago
ChatZilla now is isolated in extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2} in our source - if we make that installation item also install extensions/langpack-*@chatzilla.mozilla.org next to it, a major part of bug 408844 would be solved along with this.

Comment 2

9 years ago
Can this be made selectable or NOT installed by default?
Flags: blocking-seamonkey2.0a1?
(Reporter)

Comment 3

9 years ago
This would be something nice to have for Alpha, but it surely doesn't block us from releasing a first Alpha at all.
Flags: blocking-seamonkey2.0a1? → blocking-seamonkey2.0a1-
If nice to have, let's do it ;) If nobody is working on it, I can take this. 
(Reporter)

Comment 5

9 years ago
Would be nice if you could work on this, yes. It would probably need similar work to bug 392487 where this was done for venkman.
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
Created attachment 297531 [details] [diff] [review]
making chatzilla optional

This is making ChatZilla optional in custom installation and installed when using standard installation. Tested on WinVista, seems to work fine.
Assignee: nobody → valastiak
Attachment #297531 - Flags: review?(bugzilla)

Comment 7

9 years ago
(In reply to comment #6)
> Created an attachment (id=297531) [details]
> making chatzilla optional
> 
> This is making ChatZilla optional in custom installation and installed when
> using standard installation. Tested on WinVista, seems to work fine.
> 

Is it possible to flip this around so it is not installed on standard installation, and available through custom? I imagine less people use this service than do use it.

(Reporter)

Comment 8

9 years ago
we want to (In reply to comment #7)
> Is it possible to flip this around so it is not installed on standard
> installation, and available through custom?

It's possible, but we want it to be installed by default.

Comment 9

9 years ago
(In reply to comment #8)
> we want to (In reply to comment #7)
> > Is it possible to flip this around so it is not installed on standard
> > installation, and available through custom?
> 
> It's possible, but we want it to be installed by default.
> 

I think you should file a separate bug for that, and that that's the kind of decision that would need more input than this (which is a valid enhancement either way, and about which there can be little dispute, as opposed to the default option).

Furthermore, are there any other components which are currently off by default? Or would ChatZilla be the first?
 (In reply to comment #7)
> (In reply to comment #6)
> 
> Is it possible to flip this around so it is not installed on standard
> installation, and available through custom? I imagine less people use this
> service than do use it.
> 

My personal opinion: this is a SUITE and ChatZilla is important part of it. Making possibility to choose whether install or not in custom installation is sufficient enough. What do you think, what is the majority of SM users - those who use DOMi, Venkman or even Composer or those who do not use them. I guess the second answer is right. Should we disable those by default?


(In reply to comment #9)
> 
> Furthermore, are there any other components which are currently off by default?
> Or would ChatZilla be the first?
> 

DebugQA and Palm Sync are not installed by default in current trunk nightlies.

Comment 11

9 years ago
(In reply to comment #10)
> My personal opinion: this is a SUITE and ChatZilla is important part of it.
> Making possibility to choose whether install or not in custom installation is
> sufficient enough. What do you think, what is the majority of SM users - those
> who use DOMi, Venkman or even Composer or those who do not use them. I guess
> the second answer is right. Should we disable those by default?

I don't think that we should disable them by default. The best solution IMHO would be that the installer remembers which components are installed and when the user updates SeaMonkey the components selected during the first installation are selected again and the others are already deselected.
On the other hand this topic will lose relevance when the automatic update is working as then only a few will download the complete install packets for updates.
Comment on attachment 297531 [details] [diff] [review]
making chatzilla optional

The problem is that with ChatZilla being an additional optional component, the list of optional components won't fit on the page anymore (if all components like Palm are built). The description for Venkman is no longer visible. Maybe there's some trick to use the last bit of white-space up to the horizontal line near the buttom above the Back/Next/Cancel buttons. It's not a big problem normally, but for nightly builds it is a problem. If you want to simulate building Palm extension (to test with the installer), just comment out the ${If} ${FileExists} lines for the p@m extension in custom.nsi.
r- for now...
Attachment #297531 - Flags: review?(bugzilla) → review-
Frank, can you post here a screenshot? As I said before, i have tested this patch before attaching it here on WinVista with default theme and all the components (in this case five including Palm) were displayed correctly.
Created attachment 298001 [details]
Screenshot

Below JavaScript Debugger the description is missing.
Err, huh, now that I look closer something else is wrong here ;). I'll check again later.
I'm out of my building machine (until monday), but something is wrong in your build according to the screenshot - venkman's description is used for palm sync extension. I will check this again on monday even with XP, but as far I remember this was displayed correctly in my build. Did you apply the patch correctly? 
Yes, mismerge on my side (due to another patch). Looks correct actually.

Updated

9 years ago
Attachment #297531 - Flags: review- → review?(bugzilla)

Comment 18

9 years ago
(In reply to comment #10)
>  (In reply to comment #7)
> > (In reply to comment #6)
> > 
> > Is it possible to flip this around so it is not installed on standard
> > installation, and available through custom? I imagine less people use this
> > service than do use it.
> > 
> 
> My personal opinion: this is a SUITE and ChatZilla is important part of it.
> Making possibility to choose whether install or not in custom installation is
> sufficient enough. What do you think, what is the majority of SM users - those
> who use DOMi, Venkman or even Composer or those who do not use them. I guess
> the second answer is right. Should we disable those by default?

In a typical user installation of this sort of "suite" software, don't you think more people would use a calendar/schedule type of program before something like "Chatzilla"? Yet, the lightning extension isn't installed by default yet. I guess the mainstream use of "Chatzilla" is not really apparent.
(Reporter)

Comment 19

9 years ago
Worchester12345:
ChatZilla was always a part of the suite and installed by default, and we will not change that, esp. not because of what you "think" or "guess". You reference to Lightning/calendar has nothing to do with that, as we have no need or even possibility to chose one over the other. For one, Lightning does not support SeaMonkey at this time, for the other, nobody says we cannot include both at some point when both actually might support SeaMonkey.

For now, let's move ChatZilla from always-installed to being uncheckable in the installer but installed by default - just as it was in SeaMonkey 1.x

Comment 20

9 years ago
OK. Baby steps are better than no steps at all. Don't want to hold up progress as long as this will get addressed in the future.
Frank, any progress here?
Comment on attachment 297531 [details] [diff] [review]
making chatzilla optional

Looks good and works fine. Sorry for the delay.
Attachment #297531 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 297531 [details] [diff] [review]
making chatzilla optional

This needs an sr+ from someone as well, I suggest requesting neil@httl.net

Vlado thank you of course for the patch, and for being patient here!
Keywords: checkin-needed
(Assignee)

Updated

9 years ago
Attachment #297531 - Flags: superreview?(neil)
Comment on attachment 297531 [details] [diff] [review]
making chatzilla optional

Is it possible to reorder all the sections where you added ChatZilla to match each other? Currently you display ChatZilla first (which may well be the best place to put it) but the rest of the time you put it last.

Also, did you ask a ChatZilla representative for that description (CHATZILLA_TEXT)?
Attachment #297531 - Flags: superreview?(neil) → superreview+

Comment 25

9 years ago
The text is fine by me; it's a slightly shortened version of the short description we have on https://addons.mozilla.org/en-US/firefox/addon/16.
Created attachment 315409 [details] [diff] [review]
making chatzilla optional v2

Neil, could you take a look here again pls, if this is what you wanted. Sections are now reordered with ChatZilla on the first place. Tested on WinVista, seems to be working as expected.
Attachment #315409 - Flags: review?(neil)
Comment on attachment 315409 [details] [diff] [review]
making chatzilla optional v2

This looks like what I wanted but I think mcsmurf should have a chance to double-check.
Attachment #315409 - Flags: review?(neil) → review?(bugzilla)
Comment on attachment 315409 [details] [diff] [review]
making chatzilla optional v2

>   ; If DOMi doesn't exist then debugQA will be Field 2 (when DOMI and debugQA
>   ; don't exist, palm sync will be Field 2).
>   StrCpy $R1 2
>-  ${If} ${FileExists} "$EXEDIR\optional\extensions\inspector@mozilla.org"
>+  
>+ ${If} ${FileExists} "$EXEDIR\optional\extensions\{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}"

Can you fix that comment? It's no longer correct after the reordering (now CZ would be field 2, DOMi 3 and so on). The comment does not need to cover all optional components, it's just an explanation of how the code works. Rest looks ok.
Attachment #315409 - Flags: review?(bugzilla) → review+
Created attachment 316273 [details] [diff] [review]
making chatzilla optional v2 + fixed comment
Attachment #297531 - Attachment is obsolete: true
Attachment #316273 - Flags: superreview?(neil)
Comment on attachment 316273 [details] [diff] [review]
making chatzilla optional v2 + fixed comment

The comment change here, I don't think needs another eye, Neil and mcsmurf seem to be ok with this now.

I'll checkin within 24 hours for you.
Attachment #316273 - Flags: superreview?(neil) → review+
...that is if reed doesn't beat me to it.
Keywords: checkin-needed
mozilla/suite/installer/Makefile.in 	1.10
mozilla/suite/installer/windows/nsis/custom.nsi 	1.4
mozilla/suite/installer/windows/nsis/installer.nsi 	1.9
mozilla/suite/locales/en-US/installer/windows/custom.properties 	1.6 
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0alpha
Comment on attachment 316273 [details] [diff] [review]
making chatzilla optional v2 + fixed comment

Just for the record.
Attachment #316273 - Flags: superreview+
You need to log in before you can comment on or make changes to this bug.