Closed
Bug 409843
Opened 17 years ago
Closed 17 years ago
Unify toolbar button styles
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: sipaq, Assigned: sipaq)
References
Details
Attachments
(1 file)
58.14 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
We currently duplicate the toolbarbutton styles for Sunbird and Lightning in both calendar/base/themes/$THEME$/calendar-toolbar.css and calendar/sunbird/themes/$THEME/sunbird/calendar.css Those should be unified in the calendar/base/themes/$THEME$/calendar-toolbar.css file.
Assignee | ||
Comment 1•17 years ago
|
||
This patch removes a big amount of style duplication in our code. It is pretty large (59K), but 90% of the patch is just style or whitespace removal. The statement in line 1510 + checked="true" is a leftover from the followup patch in bug 402177 (attachment 294780 [details] [diff] [review]). Just ignore it!
Attachment #294783 -
Flags: review?(philipp)
Comment 2•17 years ago
|
||
Comment on attachment 294783 [details] [diff] [review] Patch v1 Looks good, thanks for taking care! r=philipp
Attachment #294783 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•