413523 - [Trunk] No icon images are shown in the Customize Toolbar dialog

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012120 Calendar/0.6a1

Steps to Reproduce:
1. Start Sunbird with new clean profile
2. Select menu command View -> Toolbars -> Customize Toolbars ...
3. Check the Customize Toolbar dialog

Actual Results: No icon images are displayed on the available toolbar buttons.

Expected Results: colorful icon images

Regression range: Works in Sunbird 0.6a1 (2007-12-29-05-trunk)
                  Fails in Sunbird 0.6a1 (2007-12-30-07-trunk)
  
Checkins during regression range: http://tinyurl.com/263m6c

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: overlay customizeToolbar.xul with calendar-toolbar.css

This was regressed by Bug 409843 that moved most of the the css rules for the buttons to calendar-toolbar.css. The calendar.css overlay is still required for the throbber button style.

Comment 2

[Simon Paquet [:sipaq]]

Any idea, why this only broke on trunk and not on the branch?

Comment 3

[Stefan Sitter [:ssitter]]

Yes. On Trunk we use customizeToolbar.xul from the Toolkit (Bug 363043).

On mozilla1.8 branch we can't use because of browser dependencies and other issues. Instead we use a forked version in content/calendar/customizeToolbar.xul.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 306140 [details] [diff] [review]
overlay customizeToolbar.xul with calendar-toolbar.css

Looks good, works fine, r=philipp

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Andreas Treumann]

Checked in sunbird 2008061918 -> VERIFIED