409959 - Safe mode option to disable all add-ons doesn't disable plugins

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dave Townsend [:mossop]]

When you start safe mode you get a checkbox that you can tick to disable all your add-ons and they are then disabled when starting normally. Plugins aren't affected by this.

Comment 1

[Ria Klaassen (not reading all bugmail)]

I suggest something like this:

Firefox Safe Mode
-------------------------------------------------------------------------

Firefox is now running in Safe Mode, which temporarily disables your custom settings, themes and extensions
-------------------------------------------------------------------------
You can make some or all of these changes permanent:

- Disable all extensions
- Use default theme
- Disable all plug-ins
- Reset toolbars and controls
- Reset bookmarks to Firefox default 
- Reset al user preferences to Firefox defaults
- Restore default search engines

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Isn't this a dupe of bug 342333?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Isn't this a dupe of bug 342333?

No, that talks about having plugins disabled only while in safe mode if you restart to normal mode the plugins would be enabled again, the same as happens with extensions normally. This is about the checkbox that is used to permanently disable all add-ons.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This does not block the final release of Firefox 3.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple patch that disables all plugins at the same time as the other add-ons. Since the checkbox is already labelled "Disable all add-ons" I think the expectation would be that everything in Tools - Add-ons gets disabled.

Had to add the check to the pref clear since it was throwing an exception when the default theme was already selected.

Comment 6

[Dave Townsend [:mossop]]

Landed in changeset d969f2a04e3c.