Closed Bug 410008 Opened 17 years ago Closed 17 years ago

urlbar binding should be using |this| rather than |gURLBar|

Categories

(Firefox :: Address Bar, defect)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #294697 - Flags: review?(mano)
Comment on attachment 294697 [details] [diff] [review] patch r=mano
Attachment #294697 - Flags: review?(mano) → review+
Attachment #294697 - Flags: approval1.9?
Comment on attachment 294697 [details] [diff] [review] patch a=mconnor on behalf of drivers
Attachment #294697 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/base/content/urlbarBindings.xml; /cvsroot/mozilla/browser/base/content/urlbarBindings.xml,v <-- urlbarBindings.xml new revision: 1.50; previous revision: 1.49 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Verified FIXED using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre -and- Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022806 Minefield/3.0b4pre The |this| keyword-substitution doesn't seem to have regressed anything.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: