410315 - McAfee SiteAdvisor can conflict with other extensions

Status: RESOLVED INCOMPLETE

(Plugins Graveyard :: McAfee AV, defect)

Description

[Kohei Yoshino [:kohei]]

McAfee SiteAdvisor has been conflicting with a lot of extensions:

* Minimize To Tray Enhancer
* Fast Video Download
* Irvine ContextMenu
* Internote
* ThumbStrips
* 1-ClickWeather
* Autocomplete Manager
* WOT
* Operator
* Make Link
* Translation Panel

I heard that the cause (of at least some of them) was an extra function Array.prototype.inArray added by the SiteAdvisor. The source is loaded from remote site:
https://sadownload.mcafee.com/products/sa/firefox/search.dat

Comment 2

[Kohei Yoshino [:kohei]]

I think this is a different problem from Bug 404122. Please read my description, not only summary.

Comment 3

[Dave Townsend [:mossop]]

Feel free to mention it in bug 404122 where we are already planning to do outreach to McAfee for issues. As it stands merely conflicting with other extensions is not grounds for being added to the blocklist.

Comment 4

[Kohei Yoshino [:kohei]]

http://www.google.com/search?q=siteadvisor+site:addons.mozilla.org
http://www.google.com/search?q=firefox+siteadvisor+conflict

The authors and users of over a dozen extensions have been affected by the troublesome extension. Some users have reported the problem to McAfee but the fixed version has not been available so far.

Anyway, this is completely different from Bug 404122 that for Trunk/Fx3.

Comment 5

[Dave Townsend [:mossop]]

We should reach out to McAfee and get whatever is wrong fixed as with bug 404122

Comment 6

[chris hofmann]

window, any contacts a mcafee?

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think Mark has been in contact with them.  I think their inArray method can be replaced by Array.prototype.indexOf, which is already built into FF2 and FF3.

I don't see any prototype mutation at
https://sadownload.mcafee.com/products/sa/firefox/search.dat -- has this been fixed, or is that not the right location?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

The Array prototype mutation is in a JS file downloaded by the extension, not in the extension itself.

I did trade email with a McAfee contact about the issue.

Comment 9

[Kohei Yoshino [:kohei]]

I forgot to attach a snapshot of search.dat but Array.prototype.inArray in the file was gone. Fixed?

Comment 10

[Kohei Yoshino [:kohei]]

Here's the code snippet from original code:
http://forums.mozillazine.jp/viewtopic.php?p=17452#17452

Comment 11

[Gen Kanai [:gen]]

Any updates on this bug?  We're still seeing compatibility problems for users in Japan.

Comment 12

[Kohei Yoshino [:kohei]]

The blog comments we're seeing are due to Trend Micro Internet Security (ウイルスバスター in Japan.) The SiteAdvisor problem should be fixed now.

Comment 13

[timeless]

We're now tracking such bugs. This doesn't mean it's something we can fix, merely something we hope to be able to point vendors to so they can investigate. This is an automated message.

Comment 14

[Benjamin Smedberg]

Closing old bugs in the Plugins component. We aren't going to track issues in 3rd-party plugins in the Mozilla bug tracker. In addition, support for NPAPI plugins will be removed at the end of this year; for more details see the post at https://blog.mozilla.org/futurereleases/2015/10/08/npapi-plugins-in-firefox/

If there is a serious bug in Firefox, it needs to be filed in the "Core" product, "Plug-Ins" component.