404122 - McAfee SiteAdvisor: titlebar doesn't update when switching tabs, back forward buttons don't always work. Blacklist this?

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect, P4)

Description

[Brian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1

If you are on one tab(tab1), and then you choose another tab(tab2), then titles at the top don't change.  If you are on Tab2, and you click on Tab1, Tab2's title will appear one Tab1.

Reproducible: Always

Steps to Reproduce:
1. Open at least 2 tabs.
2. Load a website with a title at the top.
3. Change tabs and look at the bar at the top and it will have the wrong title.
Actual Results:  
The title was displayed wrong.

Expected Results:  
It should have displayed the title from the selected tab.

about:buildconfig

Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
cl 	14.00.50727 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE)

Configure arguments
--enable-application=browser --enable-update-channel=beta --enable-optimize --disable-debug --disable-tests --enable-update-packaging --enable-official-branding

Comment 1

[Brian]

Attachment: Tab1

Comment 2

[Brian]

Attachment: Tab2

Comment 3

[Ria Klaassen (not reading all bugmail)]

Sounds like the work of an add-on.

Comment 4

[Brian]

I tried disabling my plugins and I was able to find out it was Mcafee SiteAdvisor cause the problem.

Comment 5

[Jesse Ruderman]

Ok.  I'm not marking this invalid yet due to the possibility that it's Firefox's fault (e.g. due to a change on trunk), but I suggest contacting the SiteAdvisor folks.

Comment 6

[Brian]

Ok, thanks.

Comment 7

[Paul Brannan]

I see this problem in Firefox 3.0b1 on Linux.  I have disabled all my plugins.

Comment 8

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2007122201 Minefield/3.0b3pre ID:2007122201

McAfee site advisor is seriously screwing up firefox trunk builds. The titlebar not changing to reflect the title of the tab's site is just one problem.

The second is that it also stops the back/forward buttons from working properly - sometimes they are greyed out when they should be clickable, and vice versa.

The third problem is that the install.rdf for McAfee SiteAdvisor v26.5 contains:
      <em:minVersion>1.0</em:minVersion>
      <em:maxVersion>4.0</em:maxVersion>

So every single person who runs this extension on branch will get hit with navigation problems when they upgrade to Firefox 3. CC'ng some people about blacklisting this extension (can that be done if the extension is not hosted on AMO?) and we also need to get McAfee made aware of their foolishness in making their extension compatible with versions of firefox still in development, and not yet released.

Comment 9

[Steve England [:stevee]]

OK I've sent them some feedback at http://www.siteadvisor.com/userfeedback.html but I don't know if it will get read by anyone. I should have mentioned in my original comment that this error is thrown in the firefox error console when changing tabs sometimes:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getFolderIdForItem]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: PU_getMostRecentBookmarkForURI :: line 1517"  data: no]

Comment 10

[Steve England [:stevee]]

Bug 404646 may be a dupe of this, or related at any rate.

Comment 11

[Steve England [:stevee]]

1. New profile, start Firefox. Note two tabs are present.
2. Go to http://www.siteadvisor.com/download/ff_preinstall.html
3. Click the radio button "I agree to these terms and conditions"
4. Click "Install Site Advisor For Firefox Now" beneath this radio button
5. "Minefield prevented this site from asking you to install software on your computer". Click "Allow"
6. "Software Installation" dialog appears. Wait for the button to count down from 5 and click "Install"
7. Add-ons window appears. Extension installs. Click "Restart Minefield"
8. "Restart Minefield" dialog appears, saying "Minefield will try to restore your tabs and windows when it restarts". Click "Restart"
9. "McAfee SiteAdvisor - Privacy Disclosure" dialog appears, click "Agree and Continue"
10. Firefox starts up; two tabs should be present ("McAfee SiteAdvisor" tab (with focus), and "Minefield Start Page")
11. In the "McAfee SiteAdvisor" tab, left click the "Analysis" heading (next to the "Download" heading - which should be the one currently selected)
12. Let the "Analysis" page load

Expected
- Back button is active, to go back a page.

Actual:
- Back button is grayed out; can't go back a page.


13. Left click on the second firefox tab "Minefield Start Page"

Expected:
- Browser title bar changes to read something to do with the Minefield Start Page

Actual:
- Browser title bar remains "SiteAdvisor - Analysis - Minefield" and error console reports:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getFolderIdForItem]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: PU_getMostRecentBookmarkForURI :: line 1517"  data: no]


14. Left click on a link in the "Minefield Start Page", eg: the one to Burning Edge (right hand side)

Expected:
- Back button is active, to go back a page.

Actual:
- Back button is grayed out; can't go back a page.


15. Left click on the first tab ("SideAdvisor - Analysis")

Expected:
- Browser title bar changes to read something to do with the Minefield Start Page

Actual:
- Browser title bar remains "The Burning Edge - Firefox nightly build changelog - Minefield" and Error Console throws the same error


16. Right click on the Refresh icon, and choose "Customize"
17. Dismiss the customization palette with the "Done" button
18. Right click on the Refresh icon again.

Expected:
- "Custommize" menu item should be selectable

Actual:
- "Customize" menu tiem is grayed out for no good reason.


19. Observe the Firefox menubar.

Expected:
- "File", "Edit", "View", etc, menus are clickable

Actual:
- "File", "Edit", "View", etc, menus are grayed out for no good reason.

Comment 12

[Steve England [:stevee]]

Don't file bugs when you've been on the whiskey kids! You make too many posts, and forget to include vital information. Such as the build your STR are for:

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2007122201 Minefield/3.0b3pre ID:2007122201

Comment 13

[Ria Klaassen (not reading all bugmail)]

These problems appear to be caused by bug 385266.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1188334620&maxdate=1188338159

Comment 14

[Ria Klaassen (not reading all bugmail)]

I see also another regression, from bug 218223 (to keep them all together).
When I go to http://www.mozilla.org/projects/firefox/ and hover over the page, e.g. the word "reasons" I see a little tooltip-like artifact that I don't see without this extension. The artifact looks like a little square on Windows XP and looks like a little button on Vista.

Comment 15

[Dave Townsend [:mossop]]

Requesting blocking here since this looks like a problem that will hit a bunch of users. I'm not saying that we should necessarily fix this ourselves for 3 (though if it is our fault then obviously that should be done), but we should figure out where the error lies and get it fixed either through our work or evangelism to McAfee. The other prospect is of course the blocklist but I would hope it wouldn't come to that.

Comment 16

[Michael Morgan [:morgamic]]

Agree.  I think the right thing to do is work with mcafee and get a fix out so users can get updated.  Blocklisting shouldn't be necessary here.

Comment 19

[[e-mail]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2

I checked with siteadvisor as only add-on.  Back button not available when going from page to page.  Also no pop up when choosing "bookmark this page".  So no pages can be bookmarked.  Just disabling, and not uninstalling siteadvisor allowed back button and bookmarking to work. (This is on a vista machine.)

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking & taking ...

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

Using a newer nightly to test and examine the Site Advisor extension:

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2007122605 Minefield/3.0b3pre

I don't see any of the above problems (comment 8, comment 9, comment 11, comment 14 and comment 19). Can someone else re-verify the issues too?

I do think the maxVersion issue in comment 8 is valid.

Comment 22

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008010312 Minefield/3.0b3pre ID:2008010312
Still reproducible for me.

Comment 23

[Ria Klaassen (not reading all bugmail)]

The extension's latest version is v26.5 and still unchanged.

Comment 24

[Mark Finkle (:mfinkle) (use needinfo?)]

I used a new profile with SiteAdvisor as the only installed extension

Comment 25

[Steve England [:stevee]]

Yes, me too mark.

Comment 26

[Mark Finkle (:mfinkle) (use needinfo?)]

Just tried with a new Minefield on Windows XP and Windows 2K:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008010211 Minefield/3.0b3pre

Can't reproduce any problems and I see no errors in the console when switching tabs.

Comment 27

[Mark Finkle (:mfinkle) (use needinfo?)]

Ok, I can now reproduce the issues. I had to restart Minefield a second time (after the extension restart). I was just making new profiles and doing a single restart after installing the extension. But now I can now see all the issues reported previously.

Sorry for the goose chase.

Comment 29

[Kev Needham [:kev]]

McAfee SiteAdvisor team has identified the code that appears to be causing the problem, and has estimated 3-4 weeks to fix, QA, and release. I've also asked them to review our versioning docs, and asked for a reset of MaxVersion to our current releases. More info as I get it.

Comment 30

[Mark Finkle (:mfinkle) (use needinfo?)]

I found out why the code (identified by McAfee team) is causing failures in other code. Site Advisor pulls a large JS file down from a server and | eval |'s the JS into global namespace. The JS has an Array.prototype.xxx definition in it, so a method is added to the Array prototype.

That will cause any code the | for each | over an Array to possibly iterate incorrectly. Of course there are several places in the Firefox UI that uses | for each | on an Array.

I am filing bugs on the fact that Firefox UI code use | for each | on an Array, but I still think Stie Advisor should workaround the issue as well, it could break other extension code. I'd also suggest Site Advisor move away from | eval | and look at loading the JS script into a sandbox or use mozIJSSubScriptLoader with a scope applied, so to not pollute the global namespace.

Comment 31

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 32

[Gen Kanai [:gen]]

Has there been any movement on this bug since March?  I ask because we're still seeing blog comments in Japan from users who are seeing Firefox crash with SiteAdvisor.

Comment 33

[Kohei Yoshino [:kohei]]

The blog comments we're seeing are due to Trend Micro Internet Security (ウイルスバスター in Japan.) The SiteAdvisor problem should be fixed now.