Filter ..apps in file picker when searching for helper applications on OS/2

RESOLVED FIXED

Status

Core Graveyard
Widget: OS/2
--
minor
RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

({fixed1.8.1.12})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
When browsing for helper applications the file picker is prefilled with a filter of "..apps" instead of "*.exe;*.cmd;*.com;*.bat", so one has to type in the right filter before actually finding any executables...

This has annoyed me far too long but I always got distracted before searching where it is set. I have definitely seen this problem on 1.8 branch and trunk. Other platforms do something with the special "..apps" filter in their nsFilePicker::AppendFilter, I think we should do that, too. Something simple along the lines of

       if (aFilter.EqualsLiteral("..apps"))
         mFilters.AppendLiteral("*.exe;*.cmd;*.com;*.bat");
       else
         mFilters.AppendString(aFilter);

should already do it but I haven't tested it so far.

Hmm, do we want .com and .bat in that list at all?
(Assignee)

Comment 1

9 years ago
Created attachment 295213 [details] [diff] [review]
this works

Urgs, searched myself to death because AppendLiteral didn't compile -- only to find out that our mFilters is an nsStringArray while the Windows version is a simple nsString. So we can use AppendString instead...

I think we should also fix this on the 1.8 branch. We just didn't have this because the OS/2 case was apparently missed in 2002 when checking in the patch for bug 97321.
Assignee: mozilla → mozilla
Status: NEW → ASSIGNED
Attachment #295213 - Flags: review?(mozilla)

Comment 2

9 years ago
Comment on attachment 295213 [details] [diff] [review]
this works

r=mkaply
Attachment #295213 - Flags: review?(mozilla) → review+
(Assignee)

Comment 3

9 years ago
Patch checked into trunk and 1.8 branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.