When browsing for helper applications the file picker is prefilled with a filter of "..apps" instead of "*.exe;*.cmd;*.com;*.bat", so one has to type in the right filter before actually finding any executables... This has annoyed me far too long but I always got distracted before searching where it is set. I have definitely seen this problem on 1.8 branch and trunk. Other platforms do something with the special "..apps" filter in their nsFilePicker::AppendFilter, I think we should do that, too. Something simple along the lines of if (aFilter.EqualsLiteral("..apps")) mFilters.AppendLiteral("*.exe;*.cmd;*.com;*.bat"); else mFilters.AppendString(aFilter); should already do it but I haven't tested it so far. Hmm, do we want .com and .bat in that list at all?
Created attachment 295213 [details] [diff] [review] this works Urgs, searched myself to death because AppendLiteral didn't compile -- only to find out that our mFilters is an nsStringArray while the Windows version is a simple nsString. So we can use AppendString instead... I think we should also fix this on the 1.8 branch. We just didn't have this because the OS/2 case was apparently missed in 2002 when checking in the patch for bug 97321.
Comment on attachment 295213 [details] [diff] [review] this works r=mkaply
Patch checked into trunk and 1.8 branch.