Last Comment Bug 410566 - Filter ..apps in file picker when searching for helper applications on OS/2
: Filter ..apps in file picker when searching for helper applications on OS/2
: fixed1.8.1.12
Product: Core Graveyard
Classification: Graveyard
Component: Widget: OS/2 (show other bugs)
: unspecified
: x86 OS/2
-- minor (vote)
: ---
Assigned To: Peter Weilbacher
Depends on:
  Show dependency treegraph
Reported: 2008-01-02 16:21 PST by Peter Weilbacher
Modified: 2014-12-09 11:27 PST (History)
0 users
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

this works (1.04 KB, patch)
2008-01-03 03:11 PST, Peter Weilbacher
mozilla: review+
Details | Diff | Splinter Review

Description User image Peter Weilbacher 2008-01-02 16:21:09 PST
When browsing for helper applications the file picker is prefilled with a filter of "..apps" instead of "*.exe;*.cmd;*.com;*.bat", so one has to type in the right filter before actually finding any executables...

This has annoyed me far too long but I always got distracted before searching where it is set. I have definitely seen this problem on 1.8 branch and trunk. Other platforms do something with the special "..apps" filter in their nsFilePicker::AppendFilter, I think we should do that, too. Something simple along the lines of

       if (aFilter.EqualsLiteral("..apps"))

should already do it but I haven't tested it so far.

Hmm, do we want .com and .bat in that list at all?
Comment 1 User image Peter Weilbacher 2008-01-03 03:11:03 PST
Created attachment 295213 [details] [diff] [review]
this works

Urgs, searched myself to death because AppendLiteral didn't compile -- only to find out that our mFilters is an nsStringArray while the Windows version is a simple nsString. So we can use AppendString instead...

I think we should also fix this on the 1.8 branch. We just didn't have this because the OS/2 case was apparently missed in 2002 when checking in the patch for bug 97321.
Comment 2 User image Mike Kaply [:mkaply] 2008-01-03 04:50:49 PST
Comment on attachment 295213 [details] [diff] [review]
this works

Comment 3 User image Peter Weilbacher 2008-01-03 05:38:28 PST
Patch checked into trunk and 1.8 branch.

Note You need to log in before you can comment on or make changes to this bug.