410575 - I don't care about default Cursive or Fantasy fonts, and I bet you don't, either

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Mark Mentovai]

In Camino:Preferences:Appearance:Fonts:Advanced…, we let users set default fonts for Cursive and Fantasy styles.  These were lightly used even when these generic family names were first introduced, and I think their use has only diminished with time.  I can't imagine any site actually specifies cursive or fantasy without reasonable fallbacks, and in any case, these guys can remain editable as hidden preferences.

I propose we eliminate the UI to set default faces for the cursive and fantasy generic families.

If we do this, we can probably get rid of the Advanced sheet altogether, although we can discuss that further or do the work in another bug.

Comment 1

[philippe (part-time)]

The fox had eliminated those a long time ago, actually...
(and as a page author, I do care about them, once every 2 years or so :-))

For the reworking of the font prefs, is bug 184102 still something to keep an eye on ? That is already much less complex than the current implementation.

Comment 2

[Stuart Morgan]

I'm all for it (especially in conjunction with removing "advanced" through something like the mocks in 184102, but without is fine too).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The main problem with getting rid of Advanced is that it is the only way (on branch) we can set fonts correctly for Asian languages (on trunk, we have no such way, because they're using yet another API for enumerating and assigning font names :/ ).

I'd really like to do away with Advanced altogether (if we can keep the new UI the height of the existing pane, because we can't make Colors & Links any bigger without the content getting lost in the empty room), but we can't yet.  Having two UIs to do the same thing is also stupid, of course, but the "enormous scolling font list UI" really sucks....

Comment 4

[Mark Mentovai]

Attachment: v1, remove Cursive and Fantasy

This removes the UI for setting Cursive and Fantasy fonts.  But we probably want to add monospaced fonts to the advanced sheet for the CJK reasons Smokey gave above.

Comment 5

[Mark Mentovai]

Attachment: v1 nib

Comment 6

[Mark Mentovai]

Attachment: v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (trunk)

Comment 7

[Mark Mentovai]

Attachment: v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (1.6)

Comment 8

[Mark Mentovai]

Attachment: v2 nib

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(See also bug 410733; there are other fonts out there that return different names to different APIs.  Suck.)

Comment 10

[Stuart Morgan]

Comment on attachment 295286 [details] [diff] [review]
v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (trunk)

r=me

>-          monospace =   {
>-              fontfamily =
>-            }

Shouldn't this still be here, since it is one of the things added to the dict? Obviously not critical; just wondering why you are removing it.

Comment 11

[Mark Mentovai]

In haste, I bet I figured that whatever came after cursive had to be fantasy.  I'll leave it in when I check this in.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 295288 [details] [diff] [review]
v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (1.6)

Erm, FWIW, this is the trunk patch again (which has a minor context conflict with our work-around-Carbon-suck stiff in Appearance.h).

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 295289 [details]
v2 nib

r=ardissone

Comment 14

[Mark Mentovai]

Attachment: v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (1.6)

Branch patch for real.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 295583 [details] [diff] [review]
v2, remove Cursive and Fantasy, add Monospace to the Advanced sheet (1.6)

When I apply this, shared works OK, but static doesn't pick up the Monospaced menu (i.e., it's got dummy items in it, instead of a list of fonts) and I can't close the sheet (or prefs, etc.) without  Force Quitting.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

2008-01-06 22:42:17.792 Camino[515] *** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value

is what I see in the Console when running static (i386, PPC under Rosetta, PPC 10.3.9)

Comment 17

[Mark Mentovai]

It sounded like the new nib got mixed up with the old code - Smokey took another look and the problem vanished for him.

Comment 18

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH before 1.6b1.