410794 - temporary downloads no longer cleaned up at shutdown (read-only)

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Simon Bünzli]

Steps to Reproduce:
1. Click on a link to a potentially sensitive Word document (alternatively: PDF, Torrent, etc.)
2. Have Firefox let the default application open that file
3. Close Word (the PDF viewer, etc.)
4. Close Firefox

Expected Results:
The temporary file is gone (Firefox silently removes it if no other application keeps it locked).

Actual Results:
That file is still sitting around (potentially with many others) and doesn't even go away with a |del %TEMP%\*.*| because it's read-only.

Manually removing the read-only flag before closing Firefox fixes this issue, so that's probably what should be happening here (not sure whether it would be OK to re-set the read-only flag if the file couldn't be removed).

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Make files writable before doing the remove. 
(I write "probably" in the code comment, since it depends on bug 401316.)

Comment 2

[Magnus Melin [:mkmelin]]

Please disregard my comment about bug 401316 - that's not related.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 295405 [details] [diff] [review]
proposed fix

+      // First make the file writable, since the tmp file is probably readonly.

s/tmp/temp/?

Comment 4

[Magnus Melin [:mkmelin]]

Nit fixed and checked in.

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.361; previous revision: 1.360
done

->FIXED

Comment 5

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011105

Thanks for the quick fix! -> VERIFIED