Closed Bug 410794 Opened 15 years ago Closed 15 years ago
temporary downloads no longer cleaned up at shutdown (read-only)
Steps to Reproduce: 1. Click on a link to a potentially sensitive Word document (alternatively: PDF, Torrent, etc.) 2. Have Firefox let the default application open that file 3. Close Word (the PDF viewer, etc.) 4. Close Firefox Expected Results: The temporary file is gone (Firefox silently removes it if no other application keeps it locked). Actual Results: That file is still sitting around (potentially with many others) and doesn't even go away with a |del %TEMP%\*.*| because it's read-only. Manually removing the read-only flag before closing Firefox fixes this issue, so that's probably what should be happening here (not sure whether it would be OK to re-set the read-only flag if the file couldn't be removed).
Summary: temporary downloads no longer clean up at shutdown → temporary downloads no longer cleaned up at shutdown (read-only)
Assignee: nobody → mkmelin+mozilla
OS: Windows XP → All
Hardware: PC → All
Make files writable before doing the remove. (I write "probably" in the code comment, since it depends on bug 401316.)
Assignee: mkmelin+mozilla → nobody
Status: ASSIGNED → NEW
Component: Download Manager → File Handling
Product: Firefox → Core
QA Contact: download.manager → file-handling
Please disregard my comment about bug 401316 - that's not related.
Comment on attachment 295405 [details] [diff] [review] proposed fix + // First make the file writable, since the tmp file is probably readonly. s/tmp/temp/?
Nit fixed and checked in. Checking in uriloader/exthandler/nsExternalHelperAppService.cpp; /cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <-- nsExternalHelperAppService.cpp new revision: 1.361; previous revision: 1.360 done ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011105 Thanks for the quick fix! -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.