41083 - Signature path not stored correctly when containing non-english characters

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Nikos Platis]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (Win98; U)
BuildID:    2000052208

Reproducible: Always

1. Create a folder whose name contains greek characters (eg. C:\Τα έγγραφά μου\, 
which, btw is the name of the "My Documents" folder in Greek Windows 9x).

2. Create a signature file in this directory (eg. sig.txt).

3. For one of your mail accounts, select this file as your signature. The path 
initially appears correct in the text box. Click the checkbox to attach this 
signature to the messages!

4. Try composing a new message from this account. No signature is attached!!

5. Review Preferences for this mail account. The signature is "C:\¤± ­³³?±?¬ 
???\sig.txt" which is obviously wrong.

6. Now close Mozilla, and hand-edit prefs.js to insert the correct path to the 
appropriate preference.

7. Rerun Mozilla, and compose a message. Now the signature is attached 
correctly.

It is obvious that Mozilla can correctly interpret the path of the signature 
file if it is correctly stored in the preference file.
Unfortunately, it seems that the path as returned from the "Choose a (signature) 
file..." dialog is somehow messed-up before being stored in the preferences.

Comment 1

[lchiang]

Belong to alec?
cc: kat

Comment 2

[Katsuhiko Momoi]

Good bug!
Modifying the path names directly may have
worked in Greek but it does not work for multi-byte languages
like Japanese. So I found two issues with Japanese path or
file names.

1. Account Settings does not save the path names properly in UTF-8.
2. Even if we supply the correct path names in UTF-8 in prefs.js,
   the signature file is not loaded.

Since any 8-bit characters need to be stored in UTF-8 in prefs.js,
converting into and converting out of pref.js file seems to be
broken.
People attach signature files quite ferquently and not being
to load it properly in different languages warrants nomination for
nsbeta2.

Comment 3

[scottputterman]

reassigning to alecf.

Comment 4

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 5

[scottputterman]

marking M17.

Comment 6

[Alec Flett]

this is turning out to be hard to fix, mainly because nsIFileSpec is not unicode 
friendly... so I looked at nsIFile, and it would probably work except that there 
is no way to persist a file descriptor with nsIFile the way you can with 
nsIFileSpec

Comment 7

[Alec Flett]

I've looked into this further, and it really doesn't look like I'll be able to
fix this for nsbeta2 unless I can get some platform people to add a persistant
to the nsIFile interface, which I think is a little risky for beta2.

Removing nsbeta2+ for reconsideration, nominating for nsbeta3

Comment 8

[Peter Trudelle]

nsbeta2-

Comment 9

[ji]

*** Bug 41606 has been marked as a duplicate of this bug. ***

Comment 10

[selmer (gone)]

Adding mail2 nomination keyword for triage effort.

Comment 11

[lchiang]

+ per mail triage.  We had called alec about this bug.

Comment 12

[Katsuhiko Momoi]

Note that Local folder path names and other path names
suffer from the same problem in many different languages.

Comment 13

[lchiang]

second pass: - per mail triage

Comment 14

[Nikos Platis]

Also note that similar problems occur during the profile conversion process by 
the Profile Manager: If a 4.x profile is stored in a folder whose pathname 
contains Greek characters (I guess it should be non-english, in general), then 
it is not converted at all and only an empty folder is created under Users50.

This may be due to the same nsIFile problem mentioned, but I thought I should 
report it.

Comment 15

[Alec Flett]

I'll be fixing this as a side effect of fixing 42102

Comment 16

[scottputterman]

sorry for the extra email. Removing mail2 keyword.

Comment 17

[Alec Flett]

filters/search UI->gayatrib

Comment 18

[Alec Flett]

oops, back to me

Comment 19

[Alec Flett]

Attachment: support nsILocalFile in the account manager

Comment 20

[Alec Flett]

Attachment: fix nsIMsgIdentity API

Comment 21

[Alec Flett]

Attachment: update am-main.xul to use nsILocalFile

Comment 22

[Alec Flett]

removing keyword cruft

Comment 23

[Scott MacGregor]

alec, in the first patch, why did you drop the var for the children variable:
-  var children = treechildren.childNodes;
+  children = treechildren.childNodes;

was children already defined?
everything else looks good..

sr=mscott

Comment 24

[Alec Flett]

yeah, that was just a warnings fix..
thanks

Comment 25

[(not reading, please use [e-mail] instead)]

r=sspitzer

sorry for the delay.

adding racham to the cc list in case you want him to review / test / land these
mailnews patches for you.

Comment 26

[(not reading, please use [e-mail] instead)]

adding patch keyword.

Comment 27

[Frank Tang]

important for intl user

Comment 28

[Jaime Rodriguez, Jr.]

Reassigning to scottip per Nav Triage Meeting. This is MailNews issue, and Alec
now works in Nav.

Comment 29

[Jaime Rodriguez, Jr.]

Adding Jenm to cc: list.

Comment 30

[Katsuhiko Momoi]

QA contact to ji. Thanks!

Comment 31

[Fabian Guisset]

this has a patch, r=, and sr=.. what are we waiting for?

Comment 32

[Boris Zbarsky [:bzbarsky]]

timeless came up with an updated patch.  He's gone to sleep, so I'm attaching it
for him. Could people r=/sr= ?

Comment 33

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated patch

Comment 34

[Alec Flett]

thanks guys, sr=alecf

Comment 35

[timeless]

fix checked in

Comment 36

[ji]

Verified with 04/17 builds.