410956 - Provide obvious access to a search engine plugin list

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

Once we support installing OpenSearch plugins from pages with lists of them (bug 410955), we should have a page with a list of good sources, and an obvious way for users to find it: an entry in the search dropdown list, or perhaps a link of some kind in the manager.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The list should live at http://caminobrowser.org/documentation/search/ (see bug 410958).

However, we won't update that until right before the 1.6 release, so we should point the in-client URL at something else that we redirect to, say, the wiki, until release.

Comment 2

[Stuart Morgan]

Attachment: client-side fix

This adds a menu item called "Find Search Engines…" to the end of the search menu, which when selected opens a new window with the url:
http://caminobrowser.org/documentation/searchplugins/
which we can redirect as needed.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 303783 [details] [diff] [review]
client-side fix

>Index: src/browser/BrowserWindowController.mm
>===================================================================
>+- (IBAction)findSearchEngines:(id)sender
>+{
>+  NSString* findEnginesPage = NSLocalizedStringFromTable(@"FindEnginesPage", @"WebsiteDefaults", nil);
>+  if (![findEnginesPage isEqualToString:@"FindEnginesPage"])
>+    [self openNewWindowWithURL:findEnginesPage referrer:nil loadInBackground:NO allowPopups:NO];
>+}
>+

Any reason this is always opening a window instead of respecting the tab-or-window pref like all of our other menu items do?  That's annoying ;)

Comment 4

[Stuart Morgan]

Attachment: v2

Perhaps sir would prefer this version?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 303825 [details] [diff] [review]
v2

Much nicer; r=ardissone :)

We should coordinate landing this   with .htaccess changes for the website (or ensure changes have been made) to redirect to a temporary page instead of sending nightly users to a 404.

For the moment, I've got http://wiki.caminobrowser.org/Development:Planning:Search_Engine_Plug-ins to collect links, but if we're going to host plug-ins for js-install, we'll need an actual web page....

Comment 6

[Stuart Morgan]

Attachment: v3

Oops, somewhere along the way I lost the added validation check so that it would work on the search sheet.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 303901 [details] [diff] [review]
v3

sr=pink

Comment 8

[Stuart Morgan]

Let me know when /documentation/searchplugins works so that I can land this.

Comment 9

[Stuart Morgan]

Nevermind, I see that a minimal page is already live.

Landed on trunk and MOZILLA_1_8_BRANCH.