411664 - Bookmarks don't show up in the top menu, but show up when I manage bookmarks.

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Andre]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080110 Camino/1.6b1pre (like Firefox/2.0.0.12pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.12pre) Gecko/20080110 Camino/1.6b1pre (1.8.1.12pre 2008011000)

After installing the latest build My bookmarks disappeared from the top menu, but show up when I manage bookmarks.

Reproducible: Always

Steps to Reproduce:
1.Did permissions
2.re-booted
3.imported them
Actual Results:  
Still same problem.

Comment 1

[Stuart Morgan]

(In reply to comment #0)
> 3.imported them

If you actually imported your bookmarks, rather than just leaving them in place (which is all you need to do to keep using them from version to version), then they are in new collections, and need to be moved into the correct folders.

Are the bookmarks actually in the Bookmarks Menu collection that is at the top of the list on the left side of the bookmark manager?

Comment 2

[[e-mail]]

For what its wort I see the exact thing.
All my bookmarks show up in about:bookmarks, but not in the Bookmarks menu.

Using my own 1.8 branch build (source pulled from CVS 10 minutes ago..). My previous build from January 4th. works as expected.

Comment 3

[[e-mail]]

Tested some more and found that it works as expected in the 09-Jan-2008 00:44 build, but not in the 10-Jan-2008 00:46 build (the official builds that is).
Regression range: http://tinyurl.com/22opzs

Caused by the checkins for bug 411338 maybe?

Comment 4

[Andre]

My original bookmarks do show up in the bookmark manager. Not under the bookmark menu. I also just did TT Pro and no change.

Comment 5

[Stuart Morgan]

Is there anything logged to the console?

Comment 6

[Andre]

Where's the console?

Comment 7

[Stuart Morgan]

It's probably easier to just download and run http://escapedthoughts.com/camino/CaminoDiagnostics.zip and then attach the file it creates here (please use the "Add an attachment" link above; don't paste it into the comments field). That will get any console logs plus other potentially useful info.

Comment 8

[Andre]

Attachment: bookmark diagnostic etc.

Here's the attachment requested.

Comment 9

[Stuart Morgan]

Looks like something is unhappy with one of the nils you started returning, mento, so we're probably never finishing the setup. I'm guessing this is bookmark-specific, since I can't reproduce it here.

Comment 10

[Stuart Morgan]

Now I see it. If you have a separator, it has a nil URL, and that makes code in several places angry. Making one in the manager throws a bunch of exceptions as well.

Comment 11

[Stuart Morgan]

We have a *lot* of code that uses URL without null-checking. I was surprised that you were able to switch from @"" to nil so easily; I guess now I understand why...

Comment 12

[Stuart Morgan]

We also have code like:
[foo compare:[someBookark lastVisit]]
that needs bullet-proofing as well, or date sort will explode for new bookmarks.

Comment 13

[Andre]

Okay, so what do I do?

Comment 14

[Mark Mentovai]

Doh, I've never used separators.  I'll fix this.

Comment 15

[Stuart Morgan]

It's probably not worth tracking down and fixing all the url usage, vs. just making the accessor return @"" if the URL is nil.

Comment 16

[Andre]

just
making the accessor return @"" if the URL is nil.

explain and how?

Could this also be fixed in the next build?

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

[e-mail], there's nothing more for you to do right now; all of the rest of the talk is us discussing the proper way to fix this bug :-)  After the bug is marked FIXED, you can (usually the next day) download a new nightly and your missing bookmarks will be visible again.

Thanks for reporting this bug!

Comment 18

[Mark Mentovai]

Attachment: Fix

Comment 19

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH for 1.6b1.