412133 - forgot to cite bug 411630 in my latest commit

Status: RESOLVED FIXED

(mozilla.org :: CVS: Administration, task)

Description

[Brendan Eich [:brendan]]

See the URL. The message was good and long, but missing the bug 411630 citation and r=igor. Hope this is easy to fix by just prepending a line like this one:

Fixes and improvements for property instrumentation (411630, r=igor).

to the commit message. Thanks,

/be

Comment 1

[Brendan Eich [:brendan]]

Pathnames and revs for my landing:

js/src/Makefile.ref 3.47
js/src/js.c 3.183
js/src/jsapi.c 3.384
js/src/jsarena.c 3.36
js/src/jscntxt.h 3.181
js/src/jsemit.c 3.296
js/src/jsemit.h 3.90
js/src/jsgc.c 3.259
js/src/jshash.c 3.19
js/src/jshash.h 3.11
js/src/jsinterp.c 3.402
js/src/jsobj.c 3.413
js/src/jsobj.h 3.77
js/src/jsparse.c 3.324
js/src/jsparse.h 3.56
js/src/jsscope.c 3.76
js/src/jsscript.c 3.167
js/src/jsstr.c 3.183
js/src/jsutil.c 3.28
js/src/jsutil.h 3.15
js/src/jsxml.c 3.185

/be

Comment 2

[Reed Loden [:reed]]

Just the one bonsai URL is all that is needed, fyi. :)

Comment 3

[chizu]

Commit message fixed:
U mozilla/js/src/jsxml.c
mozilla/js/src/jsutil.h rev:3.15
U mozilla/js/src/jsutil.h
mozilla/js/src/jsutil.c rev:3.28
U mozilla/js/src/jsutil.c
mozilla/js/src/jsstr.c rev:3.183
U mozilla/js/src/jsstr.c
mozilla/js/src/jsscript.c rev:3.167
U mozilla/js/src/jsscript.c
mozilla/js/src/jsscope.c rev:3.76
U mozilla/js/src/jsscope.c
mozilla/js/src/jsparse.h rev:3.56
U mozilla/js/src/jsparse.h
mozilla/js/src/jsparse.c rev:3.324
U mozilla/js/src/jsparse.c
mozilla/js/src/jsobj.h rev:3.77
U mozilla/js/src/jsobj.h
mozilla/js/src/jsobj.c rev:3.413
U mozilla/js/src/jsobj.c
mozilla/js/src/jsinterp.c rev:3.402
U mozilla/js/src/jsinterp.c
Fixes and improvements for property instrumentation (411630, r=igor).
mozilla/js/src/jshash.h rev:3.11
U mozilla/js/src/jshash.h
mozilla/js/src/jshash.c rev:3.19
U mozilla/js/src/jshash.c
mozilla/js/src/jsgc.c rev:3.259
U mozilla/js/src/jsgc.c
mozilla/js/src/jsemit.h rev:3.90
U mozilla/js/src/jsemit.h
mozilla/js/src/jsemit.c rev:3.296
U mozilla/js/src/jsemit.c
mozilla/js/src/jscntxt.h rev:3.181
U mozilla/js/src/jscntxt.h
mozilla/js/src/jsarena.c rev:3.36
U mozilla/js/src/jsarena.c
mozilla/js/src/jsapi.c rev:3.384
U mozilla/js/src/jsapi.c
mozilla/js/src/js.c rev:3.183
U mozilla/js/src/js.c
mozilla/js/src/Makefile.ref rev:3.47
U mozilla/js/src/Makefile.ref
--
Reading existing commit messages...
Running external editor on commit message...
--
Your revised log message is:
--------
Fixes and improvements for property instrumentation (411630, r=igor).

* Menu of -D flags for enabling instrumentation, as a commented-out CFLAGS +=
  setting for convenient testing.
* js_FindProperty and js_LookupPropertyWithFlags return indexes into the scope
  and prototype chains, respectively, to support internal instrumentation, and
  to pave the way for the return of the property cache (bug 365851)..
* jsutil.[ch] JSBasicStats struct and functions for computing mean/sigma/max
  and auto-scaling histogram.
* JS_SCOPE_DEPTH_METER instrumentation for compile- and run-time scope chain
  length instrumentation:
+ At compile time, rt->hostenvScopeDepthStats and rt->lexicalScopeDepthStats
  meter scope chains passed into the compile and evaluate APIs.
+ At runtime, rt->protoLookupDepthStats and rt->scopeSearchDepthStats track
  steps along the prototype and scope chains until the sought-after property
  is found.
* JS_ARENAMETER uses JSBasicStats now.
* Added rt->liveScopePropsPreSweep to fix the property tree stats code that
  rotted when property tree sweeping moved to after the finalization phase.
* Un-bitrotted some DEBUG_brendan code, turned some off for myself via XXX.
* Mac OS X toolchain requires initialized data shared across dynamic library
  member files, outlaws common data, so initialize extern metering vars.
* Old HASHMETER code in jshash.[ch] is now JS_HASHMETER-controlled and based
  on JSBasicStats.
* DEBUG_scopemeters macro renamed JS_DUMP_SCOPE_METERS; uses JSBasicStats now.
* Disentangle DEBUG and DUMP_SCOPE_STATS (now JS_DUMP_PROPTREE_STATS) and fix
  inconsistent thread safety for liveScopeProps (sometimes atomic-incremented,
  sometimes runtime-locked).
* Compiler-modeled maxScopeDepth will propagate via JSScript to runtime for
  capability-based, interpreter-inlined cache hit qualifier bits, to bypass
  scope and prototype chain lookup by optimizing for common monomorphic get,
  set, and call site referencing a prototype property in a well-named object
  (no shadowing or mutation in 99.9% of the cases).
--------
Ready to commit? (y/n) y
--
Applying change:
RCS file: /cvsroot/mozilla/js/src/jsxml.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsutil.h,v
done
RCS file: /cvsroot/mozilla/js/src/jsutil.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsstr.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsscript.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsscope.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsparse.h,v
done
RCS file: /cvsroot/mozilla/js/src/jsparse.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsobj.h,v
done
RCS file: /cvsroot/mozilla/js/src/jsobj.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsinterp.c,v
done
RCS file: /cvsroot/mozilla/js/src/jshash.h,v
done
RCS file: /cvsroot/mozilla/js/src/jshash.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsgc.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsemit.h,v
done
RCS file: /cvsroot/mozilla/js/src/jsemit.c,v
done
RCS file: /cvsroot/mozilla/js/src/jscntxt.h,v
done
RCS file: /cvsroot/mozilla/js/src/jsarena.c,v
done
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
done
RCS file: /cvsroot/mozilla/js/src/js.c,v
done
RCS file: /cvsroot/mozilla/js/src/Makefile.ref,v
done
--
Forcing update of local mirrored repository copy for bonsai...
>f.st.o.. jsxml.c,v
>f.st.o.. jsutil.h,v
>f.st.o.. jsutil.c,v
>f.st.o.. jsstr.c,v
>f.st.o.. jsscript.c,v
>f.st.o.. jsscope.c,v
>f.st.o.. jsparse.h,v
>f.st.o.. jsparse.c,v
>f.st.o.. jsobj.h,v
>f.st.o.. jsobj.c,v
>f.st.o.. jsinterp.c,v
>f.st.o.. jshash.h,v
>f.st.o.. jshash.c,v
>f.st.o.. jsgc.c,v
>f.st.o.. jsemit.h,v
>f.st.o.. jsemit.c,v
>f.st.o.. jscntxt.h,v
>f.st.o.. jsarena.c,v
>f.st.o.. jsapi.c,v
>f.st.o.. js.c,v
>f.st.o.. Makefile.ref,v