412209 - Support full screen mode in prism webapps

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, enhancement)

Description

[Luis Villa]

Would be nice if prism respected the keyboard command for view->full screen so that prism apps could be used in a full screen mode.

Comment 1

[Antonio Gomes (tonikitoo)]

Attachment: add fullscreen support in webapps

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 338557 [details] [diff] [review]
add fullscreen support in webapps

Couldn't we store the fullscreen setting in the JSON file too? We could just use a different value and treat it as a window state.

Also, I think the sidebar block should be outside the "else" block. The sidebar should be respected regardless of fullscreen, right?

Comment 3

[Antonio Gomes (tonikitoo)]

Attachment: v0.2 - integrated to json

> Couldn't we store the fullscreen setting in the JSON file too? We could just
> use a different value and treat it as a window state.

done.

> Also, I think the sidebar block should be outside the "else" block. The sidebar
> should be respected regardless of fullscreen, right?

no need after step above.

Comment 4

[Antonio Gomes (tonikitoo)]

Attachment: v0.3

indentation changed accidentally.

see comment #3 for description

Comment 5

[Matthew Gertner]

Comment on attachment 338858 [details] [diff] [review]
v0.3

Why do we need the ui.fullscreen pref? Won't the normal load/saveSettings methods remember the fullscreen state and restore it if necessary (with a bit of additional code in those methods).

Also, I think that the full screen constant should be a global const value, not a member variable:

const FULL_SCREEN_STATE_MASK = 0x4;

Comment 6

[Antonio Gomes (tonikitoo)]

Attachment: v0.4

addressed comments from matthew and mark.

Comment 7

[Antonio Gomes (tonikitoo)]

Attachment: simpler approach

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 338971 [details] [diff] [review]
simpler approach

nice

Comment 9

[Antonio Gomes (tonikitoo)]

Attachment: simpler approach - (unbitrotted) [Checkin: Comment 10]

un-bitrotted patch.

checking re-ping.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Completed: At revision: 19012

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 342709 [details] [diff] [review]
simpler approach - (unbitrotted)
[Checkin: Comment 10]


(In reply to comment #10)

http://viewvc.svn.mozilla.org/vc?view=rev&revision=19012

Comment 13

[Eldmannen]

How about a --fullscreen command-line option?