Last Comment Bug 450333 - merge prism maemo changes into prism trunk
: merge prism maemo changes into prism trunk
Status: NEW
:
Product: Mozilla Labs
Classification: Other
Component: Prism (show other bugs)
: unspecified
: Other Linux
: -- normal (vote)
: ---
Assigned To: Antonio Gomes (tonikitoo)
:
Mentors:
Depends on: 412209 412212 443919 460555
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-12 17:53 PDT by Antonio Gomes (tonikitoo)
Modified: 2008-10-21 07:32 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
maemo changes (diff as is) (17.50 KB, patch)
2008-08-13 19:59 PDT, Antonio Gomes (tonikitoo)
no flags Details | Diff | Splinter Review

Description Antonio Gomes (tonikitoo) 2008-08-12 17:53:55 PDT
meta bug to track prism changes for maemo.
Comment 1 Antonio Gomes (tonikitoo) 2008-08-13 19:59:40 PDT
Created attachment 333678 [details] [diff] [review]
maemo changes (diff as is)

these are the main changes inside /prism dir for prism-maemo. thoughts , mfinkle ?

some points to be improved:

* it is not yet integrated to fennec's xulrunner neither to fennec itself as we want for the future.

* instead, it integrates w/ microb as following: there is a external .py file to handle open_mime for prism, and there is another external .sh script to call microb whenever an external link is opening. See:

/usr/bin/run-prism_maemo.py   
/usr/bin/run-prism_maemo.sh   
/usr/bin/run-prism_microb.sh

* I have done my own /debian directory.

* it includes my softkb patch in bug 406837, so works fine in n800.

after installing prism-maemo (I know, this is extremely ugly, but at port inital stage I had to show it in a international conference).
Comment 2 Matthew Gertner 2008-08-14 05:34:59 PDT
I'm not sure I'm superthrilled about having a bunch of Maemo-specific #ifdefs spread through the code. If we end up supporting a few different platforms like this the code is going to get very messy. Can't we define some abstract interfaces or configuration files in the appropriate areas instead?

For example, there should be a separate file to define which shortcut destinations are available on each platform. I'm not sure I understand Maemo behavior if there is no shortcut destination (you have an #ifdef around the check).

What are the XUL changes in install-shortcut.xul needed for?

Maybe an optional .css file available for each platform?

The createShortcut code is a mess anyway. We should clean this up and move each platform into its own file (or even directory).

How come the external protocol service is not used on Maemo?

Couldn't the fullscreen/zoom stuff be generalized to work on all platforms?
Comment 3 Mark Finkle (:mfinkle) (use needinfo?) 2008-08-14 06:46:12 PDT
* Fullscreen should be added for all platforms, not just Maemo
* Let's try to make platform changes (even #ifdefs) in CSS to hide XUL or change widths, instead of using conditionals in the XUL
* Let's try to use less conditionals in the createShortcut stuff. For example, we could add a Directory Provider for Maemo to use (instead of "Desk")
* Overall, I am not against using NS_OSSO conditionals, but we could try to be smarter about how we use them and try to minimize them.

Great work, Antonio

Note You need to log in before you can comment on or make changes to this bug.