412252 - Make it easier for extensions to overlay the TB context-menus by adding IDs

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Simon Paquet [:sipaq]]

The Thunderbird context-menus are currently very hard to extend for extensions, because they lack IDs in some places. In consequence it is very hard to add items to the context-menu or hide items from TB and one has to hack around this issue.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: Patch

This patch adds the missing IDs to the context-menus. In a few places I replaced the context-menu IDs with IDs that use the general style of ID naming in the file.

I'll also add a diff -uw patch for easier review.

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch (diff -uw6 for easier review)

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 320256 [details] [diff] [review]
Patch

messagePaneContext-afterMarkFlagged should use -sep- like all the other separators, for consistency

Comment 4

[Magnus Melin [:mkmelin]]

Fixed that, and checked in.

Checking in mail/base/content/mailContextMenus.js;
/cvsroot/mozilla/mail/base/content/mailContextMenus.js,v  <--  mailContextMenus.js
new revision: 1.33; previous revision: 1.32
done
Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.240; previous revision: 1.239
done
Checking in mail/base/content/nsContextMenu.js;
/cvsroot/mozilla/mail/base/content/nsContextMenu.js,v  <--  nsContextMenu.js
new revision: 1.21; previous revision: 1.20
done

->FIXED