Closed Bug 412272 Opened 13 years ago Closed 9 years ago

Check boxes in list boxes should display an Mac OS X conform image

Categories

(Calendar :: Calendar Frontend, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chris.j.bugzilla, Assigned: Paenglab)

Details

(Whiteboard: [good first bug][mentor=Fallen][lang=css])

Attachments

(3 files, 1 obsolete file)

Currently Win XP check boxes are displayed on Mac OS X. This looks somehow strange. "Native" check boxes should be displayed instead. See example attached.
This issue applies to all non Windows XP systems. The current solution only works ok on Windows XP. On other systems like Linux or Windows 2000 etc. the checkbox looks wrong.
While its quite easy to differ between winstripe and pinstripe, I don't think its easy to differ between win2k, winxp and linux? Or can theme images be OS specific?
They can, and we have different themes for windows classic an aero now. We can even differ gnome checkboxes!
Whiteboard: [good first bug][mentor=Fallen][lang=css]
Attached patch patch (obsolete) — Splinter Review
The Aqua checkbox image was already added with Bug 512779. This patch adds the graphite image.

The old graphic looks best for Win7 but applies also for XP and Linux. So I propose to stay as it is now. If all themes of Win and Linux should be supported then we should change to native checkboxes. I tried this but failed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #625643 - Flags: review?(philipp)
Hardware: PowerPC → All
Attached patch patch v2Splinter Review
Unbitrotted patch after landing of bug 754552.
Attachment #625643 - Attachment is obsolete: true
Attachment #625643 - Flags: review?(philipp)
Attachment #627125 - Flags: review?(philipp)
Comment on attachment 627125 [details] [diff] [review]
patch v2

Review of attachment 627125 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp

::: calendar/base/themes/pinstripe/calendar-task-tree.css
@@ -49,4 @@
>  .calendar-task-tree > treechildren::-moz-tree-image(calendar-task-tree-col-completed, overdue),
>  .calendar-task-tree > treechildren::-moz-tree-image(calendar-task-tree-col-completed, future),
>  .calendar-task-tree > treechildren::-moz-tree-image(calendar-task-tree-col-completed, inprogress) {
> -    list-style-image: url(chrome://calendar/skin/checkbox-images.png);

What happens if the system metric does not advertise mac-graphite-theme ? From this patch alone I cannot see if these rules inherit the list-style-image from something else, please make sure thats the case.
Attachment #627125 - Flags: review?(philipp) → review+
Good catch. I forgot in the patch to remove the ', completed' in:

@@ -42,6 +42,16 @@
 .calendar-task-tree > treechildren::-moz-tree-image(calendar-task-tree-col-completed, completed),
 .calendar-task-tree-col-completed {
     list-style-image: url(chrome://calendar/skin/checkbox-images.png);
+}
+
+.calendar-task-tree:-moz-system-metric(mac-graphite-theme)
+> treechildren::-moz-tree-image(calendar-task-tree-col-completed, completed),
+.calendar-task-tree-col-completed:-moz-system-metric(mac-graphite-theme) {
+    list-style-image: url(chrome://calendar/skin/checkbox-images-graphite.png);
+}

I'll check-in this patch with this corrected.
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/e1da0f98ebcf>
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.7
You need to log in before you can comment on or make changes to this bug.