412339 - Hard to read diff views

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

When looking at a diff for sumo article revisions, it's hard to tell what the difference is. For instance, many lines in the source of an article can be very long (probably a result of bug 398358), and if someone makes a spelling correction, I have to read the entire line and compare it with the previous version to find the difference.

Comment 1

[David Tenser [:djst]]

I agree on this. Is this a simple theme issue? I see classes like diffadded, diffdeleted, etc in the html source.

Jason, would you have time to fix this?

Comment 2

[Jason Barnabe (np)]

I can add CSS to the classes if that's all there is to it.

Comment 3

[Jason Barnabe (np)]

@-moz-document domain("support.mozilla.com") {
.diffadded {
  background-color: #90ee90 !important;
}
.diffdeleted {
  background-color: #EE8070 !important;
}
.diffchar {
  background-color: yellow !important;
}
}

Cram that in your favourite user style extension or userContent.css and tell me what you think.

Added lines are in green. Removed lines are in red. For changes, there will be an add a remove line, and the exact text that changed will be in yellow.
Changes 

Comment 4

[Axel Hecht [:Pike]]

Much better. The default diff format is having problems with showing whitespace changes still, but that shouldn't be an overall problem, but just one that came up with the help conversions.

Comment 5

[David Tenser [:djst]]

This looks very good. 

Comment 6

[Jason Barnabe (np)]

Attachment: patch

Comment 7

[Steffen Wilberg]

When will this go live?

Comment 8

[David Tenser [:djst]]

Steffen, we should schedule a new live server push this week.

Comment 9

[Jason Barnabe (np)]

Now live.