412348 - Titles are missing in smart Bookmarks and Addressbar for urls w/out www

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; es-ES; rv:1.9b3pre) Gecko/2008011404 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; ja-JP-mac; rv:1.9b2) Gecko/2007121014 Firefox/3.0b2

After doing a major update from 2.0.0.11 -> 3.0b2, titles are missing in sites without www, that were migrated from 2.0.0.11 builds.   See screenshot

Reproducible: Always

Steps to Reproduce:
1. open 2.0.0.11 build, and generate a few bookmarks, history
2. make sure a few of them are typed w/out the "www"  (eg. "cnn.com", "msnbc.com")
3. run the major update to 3.0b2
4. open the same profile, and click the address bar dropdown.  
5. Verify for sites w/out the "www" entered, it does not have a title in the dropdown.  

** See screenshot
Actual Results:  
Missing titles after update in dropdown history for sites w/out "www" prefix

Expected Results:  
Title should appear, despite the redirect.

Can this be fixed in fx3?  or is a Fx2 bug?

Comment 1

[Tony Chung [:tchung]]

Attachment: Missing Titles in dropdown screenshot

Comment 2

[Tony Chung [:tchung]]

Theses titles are also missing in Smart bookmarks > Last visited entries.   Seems to be the same sites, that are missing the 'www'.

Interestingly, http://bugzilla.mozilla.org is also missing the title.   Something to investigate.

Switching QAcontact back to places, and adding another screenshot for the Smart Bookmarks toolbar. 

Comment 3

[Tony Chung [:tchung]]

Smart Bookmarks Image --> http://img186.imageshack.us/img186/2006/missingdescriptiontr8.png

Comment 4

[Tracy Walker [:tracy]]

I think this is a problem in 2.0.0.x, not Fx3. Fx3 somehow adds the title to these sorts of entries in the url bar.  Fx2 does not.  Fx3 can't import what is not there to begin with.  Can migration add the title based on the entry?  ie. "cnn" for cnn.com

adding "blocking1.8.1.12 ?" to get it on that radar. Just in case we need/want to fix it there.

Comment 5

[Daniel Veditz [:dveditz]]

Doesn't the migration happen after the upgrade? Are you saying this problem does not happen if you upgrade the same data using the Firefox installer?

Not going to block 1.8.1.12 because we'll likely have a 1.8.1.13 before we need to do a Major Update (don't want to update to betas). It's also not clear that it's a FF2 bug, it's much more likely to be a FF3 migration bug.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree with Dan, this is more likely something we should be taking care of on import. Blocking for this important use case.

Comment 7

[Tony Chung [:tchung]]

shoot, this is not a Major Update issue only.   I can repro this behavior going from gran Paradiso alpha 1 -> Firefox beta 3 against "betatest" channel.

this was done on windows.   I'm going to nominate to block beta 4.

i'll add another screenshot.

Comment 8

[Tony Chung [:tchung]]

Attachment: No Title screenshot on windows updated from Alpha 1

Comment 9

[Ondrej Brablc]

I have used http://www.jwz.org/hacks/mork.pl to verify that the data is missing in the input file format already. It seems to be the case of manually typed URLs which result in redirect (typically http://google.com/ and http://gmail.com/ ) but more titles are missing for URLs that were not typed manually, but I cannot find any common pattern for them. May be pages, that failed to load when they were clicked ...

Anyway, this is not a Fx3 problem and I'm reassigning to nobody, because I'm working on places and do not know Fx2 in this area (but I can learn it ;-)

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm sure there's a dupe somewhere in Places about redirecting URLs not picking up a title ...

Comment 11

[Ondrej Brablc]

(In reply to comment #10)
> I'm sure there's a dupe somewhere in Places about redirecting URLs not picking
> up a title ...

It seems like redirects have titles build from their URL (and it worked fine when I tried that). We can do the same when importing from mork. I will attach patch when CVS work again.

Comment 12

[Ondrej Brablc]

Attachment: Mark empty title as void to create one from URL

This patch fixes the mork importer to create titles for history records where it is missing. Titles are created the very same way as if links were visited from Fx3.

The bug was blocking before and I wanted it to be unblocked, because the error is in Fx2. However, this patch is trivial when done in Fx3, so I believe the bug should become blocking again.

Comment 13

[Dietrich Ayala (:dietrich)]

Comment on attachment 310491 [details] [diff] [review]
Mark empty title as void to create one from URL

r=me

Comment 14

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsMorkHistoryImporter.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsMorkHistoryImporter.cpp,v  <--  nsMorkHistoryImporter.cpp
new revision: 1.15; previous revision: 1.14
done

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv